Nov 2020

3 commits
Add pg_nodiscard function declaration specifier
11 Nov 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The commit exactly matches the first patch in #1: the 12-line pg_nodiscard definition and explanatory comment in src/include/c.h.

  • Michael Paquiersaw the final versiontrailerMichael checked compiler support and proposed an MSVC alternative in #4, then accepted omitting it after investigating analysis requirements in #6.
Add pg_nodiscard decorations to some functions
11 Nov 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The commit exactly matches the second patch in #1, adding pg_nodiscard to declarations in src/include/nodes/pg_list.h and src/include/utils/palloc.h.

  • Michael Paquiersaw the final versiontrailerMichael examined the list annotations and questioned repalloc coverage in #4, then accepted Peter's rationale in #6.
Fix cases of discarding result from list API functions
11 Nov 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

The code changes exactly match the third patch in #1, assigning list results in src/backend/commands/lockcmds.c and src/backend/parser/analyze.c modulo rebase context. The title and commit explanation were rewritten to describe an independent API cleanup preceding the warning annotations.

  • Michael Paquiersaw the final versiontrailerMichael reviewed the submitted series in #4 and #6 and is explicitly credited on this cleanup commit, although his replies do not discuss its two hunks individually.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Michael Paquier3
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.