model-writtenrun 8057 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed pg_nodiscard in #1 to catch ignored list API results, choosing a name aligned with C++ and proposed C terminology; his three patches defined the macro, annotated list and reallocation functions, and corrected two existing callers.
- Tom Lane supported the idea but questioned pgindent compatibility in #2; Peter reported in #3 that pgindent left the patched files unchanged.
- Michael Paquier examined compiler support in #4, suggested considering MSVC's _Check_return_, mentioned parsePGArray as another possible case, and questioned whether repalloc needed annotation.
- Peter distinguished MSVC analysis and error-return checking from ordinary compiler warnings and defended repalloc annotations by reference to realloc practice in #5; Michael accepted the rationale and agreed to omit the more invasive MSVC support in #6.
- Peter first landed the two caller corrections from #1 as c77f6f50e4, preserving the code changes while rewriting the commit explanation to present them as cleanup ahead of the compiler warnings.
- Peter then landed the macro as c617aea6ac and the function annotations as a378ba49a5, both unchanged from their respective patches in #1, and confirmed completion in #7; the entire submitted series landed, without MSVC-specific support or a parsePGArray addition.