minor problem in boolean cast

Started by Cary Huangalmost 6 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliestests failedCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t43137
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 20, 2026 at 12:01 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t43137_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t43137_1 && git checkout t43137_1

Patchset v1 (message #1) is on t43137_1

Jump to latest
#1Cary Huang
cary.huang@highgo.ca

Hi

I noticed that when casting a string to boolean value with input 'of' it still cast it to 'f'. I think with 'of', it should give an error because 'off' is the expected candidate. This may not be intended so I made a simple patch to address this. 

```

postgres=# select cast('of' as boolean);

bool

------

f

(1 row)

```

Cary Huang

-------------

HighGo Software Inc. (Canada)

mailto:cary.huang@highgo.ca

http://www.highgo.ca

Attachments:

t43137_1
0001-boolean-type-cast-fix.patchapplication/octet-stream; name=0001-boolean-type-cast-fix.patchDownload+1-1
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Cary Huang (#1)
Re: minor problem in boolean cast

Cary Huang <cary.huang@highgo.ca> writes:

I noticed that when casting a string to boolean value with input 'of' it still cast it to 'f'. I think with 'of', it should give an error because 'off' is the expected candidate. This may not be intended so I made a simple patch to address this. 

It's absolutely intended, and documented:

https://www.postgresql.org/docs/devel/datatype-boolean.html

Note the bit about "Unique prefixes of these strings are also accepted".

The code comment just above parse_bool() says the same.

regards, tom lane