Participants
Peter Eisentraut
Peter Eisentraut
Heikki Linnakangas
Heikki Linnakangas
Tom Lane
Tom Lane
Michael Paquier
Michael Paquier
Attachments
Download Latest Patchset
+77-2
Show all attachments
Thread Outline
#1Peter EisentrautPeter Eisentraut
Nov 02, 2020
#2Heikki Linnakangas↳Heikki Linnakangasto Peter Eisentraut (#1)
Nov 02, 2020
#3...#5
Tom LaneMichael PaquierPeter Eisentraut
↳▸to Peter Eisentraut (#1)
Nov 02, 2020
#3Tom Lane↳Tom Laneto Peter Eisentraut (#1)
Nov 02, 2020
#4Michael Paquier↳Michael Paquierto Tom Lane (#3)
Nov 03, 2020
#5Peter Eisentraut↳Peter Eisentrautto Michael Paquier (#4)
Nov 04, 2020

hash_array_extended() needs to pass down collation

Started by Peter Eisentrautover 5 years ago5 messageshackers
Jump to latest
#1Peter Eisentraut
Peter Eisentraut
peter_e@gmx.net

I noticed that hash_array_extended() does not pass down the collation to
the element's collation function, unlike hash_array(). As a
consequence, hash partitioning using text arrays as partition key fails.

The attached patch fixes this. I propose to backpatch this.

Attachments:

0001-Enable-hash-partitioning-of-text-arrays.patchtext/plain; charset=UTF-8; name=0001-Enable-hash-partitioning-of-text-arrays.patch; x-mac-creator=0; x-mac-type=0Download+77-2
#2Heikki Linnakangas
Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Peter Eisentraut (#1)
Re: hash_array_extended() needs to pass down collation

On 02/11/2020 09:40, Peter Eisentraut wrote:

I noticed that hash_array_extended() does not pass down the collation to
the element's collation function, unlike hash_array(). As a
consequence, hash partitioning using text arrays as partition key fails.

The attached patch fixes this. I propose to backpatch this.

+1. Straightforward oversight in commit 5e1963fb764e.

- Heikki

#3Tom Lane
Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: hash_array_extended() needs to pass down collation

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

I noticed that hash_array_extended() does not pass down the collation to
the element's collation function, unlike hash_array(). As a
consequence, hash partitioning using text arrays as partition key fails.

The attached patch fixes this. I propose to backpatch this.

LGTM

regards, tom lane

#4Michael Paquier
Michael Paquier
michael@paquier.xyz
In reply to: Tom Lane (#3)
Re: hash_array_extended() needs to pass down collation

On Mon, Nov 02, 2020 at 10:01:53AM -0500, Tom Lane wrote:

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

I noticed that hash_array_extended() does not pass down the collation to
the element's collation function, unlike hash_array(). As a
consequence, hash partitioning using text arrays as partition key fails.

The attached patch fixes this. I propose to backpatch this.

LGTM

+1.
--
Michael
#5Peter Eisentraut
Peter Eisentraut
peter_e@gmx.net
In reply to: Michael Paquier (#4)
Re: hash_array_extended() needs to pass down collation

On 2020-11-03 11:48, Michael Paquier wrote:

On Mon, Nov 02, 2020 at 10:01:53AM -0500, Tom Lane wrote:

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

I noticed that hash_array_extended() does not pass down the collation to
the element's collation function, unlike hash_array(). As a
consequence, hash partitioning using text arrays as partition key fails.

The attached patch fixes this. I propose to backpatch this.

LGTM

+1.

committed

← Back to Topics