Useless string ouput in error message

Started by Tang, Haiyingabout 5 years ago3 messages
#1Tang, Haiying
tanghy.fnst@cn.fujitsu.com
1 attachment(s)

Hi

I think I found a typo for the output of an error message which may cause building warning.
Please refer to the attachment for the detail.

Previous discussion:
/messages/by-id/alpine.DEB.2.21.1910311939430.27369@lancre

Best regards
Tang

Attachments:

0001-Remove-useless-s.patchapplication/octet-stream; name=0001-Remove-useless-s.patchDownload
From 44c7748b00225d0990159cecce1f37a7de2526d5 Mon Sep 17 00:00:00 2001
From: tanghy <tanghy.fnst@cn.fujitsu.com>
Date: Mon, 9 Nov 2020 17:26:51 +0900
Subject: [PATCH] Remove useless %s

---
 src/fe_utils/cancel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/fe_utils/cancel.c b/src/fe_utils/cancel.c
index 7004201748..0a385647df 100644
--- a/src/fe_utils/cancel.c
+++ b/src/fe_utils/cancel.c
@@ -207,7 +207,7 @@ consoleHandler(DWORD dwCtrlType)
 			}
 			else
 			{
-				write_stderr(_("Could not send cancel request: %s"));
+				write_stderr(_("Could not send cancel request: "));
 				write_stderr(errbuf);
 			}
 		}
-- 
2.27.0.windows.1

#2Magnus Hagander
magnus@hagander.net
In reply to: Tang, Haiying (#1)
Re: Useless string ouput in error message

On Mon, Nov 9, 2020 at 9:39 AM Tang, Haiying <tanghy.fnst@cn.fujitsu.com> wrote:

Hi

I think I found a typo for the output of an error message which may cause building warning.
Please refer to the attachment for the detail.

Previous discussion:
/messages/by-id/alpine.DEB.2.21.1910311939430.27369@lancre

Yeah, this looks like a copy/paste error. Pushed and backpatched to 13
where it was introduced.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

#3Fabien COELHO
coelho@cri.ensmp.fr
In reply to: Magnus Hagander (#2)
Re: Useless string ouput in error message

I think I found a typo for the output of an error message which may cause building warning.
Please refer to the attachment for the detail.

Indeed. Thanks for the fix!

--
Fabien.