Sep 2021

1 commit
Disallow extended statistics on system columns
19 Sep 2021Tomas Vondramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14rc1
LLM analysis, 100% surelanded as postedfrom patchset #1031 of 1 reviewer saw the final version

The statscmds.c additions exactly match #103: pull_varattnos(), bitmap iteration and rejection of nonpositive attribute numbers; #107 confirms the push.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureExplicitly supported rejecting system-attribute expressions in #106 while separately questioning restrictions on constant expressions.

Aug - Sep 2021

2 commits
Identify simple column references in extended statistics
1 Sep 2021Tomas Vondramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14rc1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #991 of 1 reviewer saw the final version

Takes the column-reference fix from #99, retaining the Var checks and regression case with expanded explanatory comments; the misplaced pg_dump expectation belongs to the separately committed parentheses fix.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureReported the redundant-statistics behavior in #97 and explicitly endorsed both fixes after examining their scope in #102.
Don't print extra parens around expressions in extended stats
31 Aug 2021Tomas Vondramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14rc1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #991 of 1 reviewer saw the final version

Combines the parentheses fix and expected-output changes from the first patch in #99 with its pg_dump expectation mistakenly placed in the second patch, as identified in #100.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureReported the remaining extra parentheses in #96, corrected the test-hunk placement in #100, and endorsed applying both patches in #102.

Jun 2021

2 commits
Change position of field "transformed" in struct CreateStatsStmt.
11 Jun 2021Noah Mischmaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements Noah's announced field-order correction in #94, moving transformed before if_not_exists in CreateStatsStmt and its initialization; no attachment contains this change.

Add transformed flag to nodes/*funcs.c for CREATE STATISTICS
6 Jun 2021Tomas Vondramaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Adds transformed handling to copyfuncs.c, equalfuncs.c and outfuncs.c after Noah's report in #89; #90 identifies the resulting commit, and no attached patch contains the fix.

  • Noah Mischsaw an earlier versionLLM analysis, 94% sureIdentified the missing node-function handling in #89 before the fix landed, but did not review the thread's final attached patch #103.

Mar 2021

5 commits
Stabilize stats_ext test with other collations
27 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Responds to Tomas's locale-dependent buildfarm failure report in #86, replacing concatenation expressions with upper() in stats_ext tests; no pre-commit attachment supplies this fix.

Extended statistics on expressions
26 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #821 of 3 reviewers saw the final version

Combines the feature and remaining test reductions from #82, with existing-test reductions committed separately; final edits relocate StatisticsGetRelation(), preserve statistics comments during type changes, and add expression display to psql's extended-statistics listing.

  • Justin Pryzbysaw an earlier versiontrailerSupplied fixes and extensive testing, including the sqlsmith and invalid-relation reports in #63 and #77, before the final dependency correction and additional committer changes.
  • Dean Rasheedsaw the final versiontrailerReviewed the final attached series in #83, proposing the function relocation, comment preservation and final documentation corrections incorporated into the commit.
  • Zhihong Yusaw an earlier versiontrailerReviewed cleanup, memory handling and helper functions in #29, before the expression-numbering, build-data and ndistinct reworks.
Reduce duration of stats_ext regression tests
26 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #821 of 1 reviewer saw the final version

Extracts only the pre-existing ndistinct and functional-dependency test reductions from #82, changing dataset sizes and expected estimates before the expression feature lands.

  • Dean Rasheedsaw the final versionLLM analysis, 92% sureSaid he had looked over the updated series and found it in good shape in #83, following the test-reduction submission in #82.
Allow composite types in catalog bootstrap
23 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #522 of 2 reviewers saw the final version

Takes Justin's composite-type bootstrap prerequisite, most recently forwarded in #52, with revised comments and removal of the did_reread restriction so repeated type-list reloads remain possible.

  • Dean Rasheedsaw the final versiontrailerReviewed the bootstrap prerequisites in #16 and endorsed starting the commit process for the updated series in #60.
  • Tomas Vondrasaw the final versiontrailerAccepted Justin's revised prerequisites in #50 and explained his final reload changes when announcing their commit in #61.
Convert Typ from array to list in bootstrap
23 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #522 of 2 reviewers saw the final version

Takes the array-to-List bootstrap prerequisite from #52, originally revised by Justin in #49; the implementation is retained with populate_typ renamed to populate_typ_list and corresponding comment edits.

  • Dean Rasheedsaw the final versiontrailerFlagged stale array-oriented names and comments in #16, then endorsed committing the updated series in #60.
  • Tomas Vondrasaw the final versiontrailerIntegrated Justin's updated list conversion and explained why he retained it when announcing the bootstrap commits in #61.

Jan 2021

1 commit
Disallow CREATE STATISTICS on system catalogs
15 Jan 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.2+3 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #230 of 1 reviewer saw the final version

Extracts the allowSystemTableMods/IsSystemRelation check already attached in #23, with regression tests adapted to use an ordinary table independently of expression support.

  • Dean Rasheedsaw an earlier versionLLM analysis, 98% sureIdentified the missing system-catalog restriction while reviewing #15 in #16, prompting the new check attached in #23.

Credits across 11 commits

Author
Tomas Vondra3 LLM6
Justin Pryzby2
Reviewer
Dean Rasheed3
Tomas Vondra2
Justin Pryzby1
Zhihong Yu1
Reported by
Dean Rasheed1
Justin Pryzby1
Mark Dilger1
Noah Misch1
Committer
Tomas Vondra10
Noah Misch1

N LLM means N of the credits come from LLM analysis, not from commit trailers.