Jul 2021

2 commits
Remove newly added useless assertion check
26 Jul 2021Alvaro Herreramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Tom Lane challenged the assertion in #39, and Alvaro confirmed its removal in #40. The commit removes the found counter and assertion from renametrig_partition in src/backend/commands/trigger.c and adds a break after the first match; no attachment contains this follow-up.

  • Tom Lanesaw the final versionLLM analysis, 100% sureBefore the fix committed, Tom reported Coverity's objection and explained why the counter/assertion should be replaced or removed in #39, prompting the correction confirmed in #40.
Make ALTER TRIGGER RENAME consistent for partitioned tables
22 Jul 2021Alvaro Herreramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #330 of 1 reviewer saw the final version

The commit matches #33 across all four files, with light changes to the clone-rename error and hint, a corrected pg_dump comment, whitespace, and corresponding expected output; #37 confirms these minor corrections. Its co-author credit identifies Arne Roland, who originated the patch in #1, alongside sender Alvaro Herrera.

  • Zhihong Yuno review foundtrailerAlthough credited by the commit, the supplied discussion shows only a rebase request in #17 and an empty stripped message in #19, so substantive review coverage cannot be established.

Credits across 2 commits

Reviewer
Zhihong Yu1
Co author
Alvaro Herrera1
Arne Roland1
Committer
Alvaro Herrera2