Dec 2020

2 commits
Add pg_alterckey utility to change the cluster key
26 Dec 2020Bruce Momjianmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #750 of 1 reviewer saw the final version

Takes the pg_alterckey member of the two-component submission #75, preserving its five changed paths and rotation/recovery structure. src/bin/pg_alterckey/pg_alterckey.c gains explicit hexadecimal decoding and GCM cipher contexts, with additional error-path and wording changes.

  • Michael Paquiersaw an earlier versionLLM analysis, 97% sureMichael challenged the utility's backend-header dependency in #27, leading to the postgres_fe.h correction confirmed in #28, before subsequent direct-key and GCM changes.
Add key management system
25 Dec 2020Bruce Momjianmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: Internal key management system (not this thread)
LLM analysis, 99% surepart of a posted patchsetsignificant changesfrom patchset #751 of 5 reviewers saw the final version

Takes the key-manager component of #75, which postdates every supplied patchset in thread #41874, but replaces CBC/HMAC wrapping with GCM and redesigns CryptoKey and the cipher API in src/common and src/include/common. The commit credits Masahiko Sawada, Bruce Momjian, and Stephen Frost; it excludes the rotation utility, and hexadecimal decoding already exists in its parent tree.

  • Michael Paquiersaw an earlier versionLLM analysis, 99% sureMichael identified duplicate OpenSSL initialization, resource-cleanup problems, and inadequate cipher/HMAC separation in #3, #23, and #37, before the direct-key and GCM rework.
  • Daniel Gustafssonsaw an earlier versionLLM analysis, 98% sureDaniel reviewed the evolving version following #2, identifying unused OpenSSL declarations, header-guard problems, documentation errors, and API coupling in #13, with fixes acknowledged in #17.
  • Neil Chensaw an earlier versionLLM analysis, 87% sureNeil tested online revisions following #2 and reported wrapped bootstrap keys and inconsistent key-length units in #24, prompting the bootstrap correction in #29.
  • Alastair Turnersaw an earlier versionLLM analysis, 96% sureAlastair examined ossl_cipher_ctx_create and challenged its wrapping construction in #82, before the committed GCM implementation replaced the CBC/HMAC design in #75.
  • Bruce Momjiansaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Bruce MomjianLLM1
Masahiko Sawada1
me1
Stephen Frost1
Reviewer
Bruce Momjiancommitter1
Committer
Bruce Momjian2

N LLM means N of the credits come from LLM analysis, not from commit trailers.