model-writtenrun 7631 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andrew Dunstan proposed installation-aware TAP nodes to test NSS and OpenSSL builds together, with cross-version testing as another use, initially sketching a PostgresNode subclass that temporarily adjusts executable and library paths #1.
- Michael Paquier favored keeping installation paths on nodes, questioned the need for a separate module, and identified conversion of pg_upgrade tests to TAP as a benefit #2; Andrew subsequently shared a working prototype and typo correction #3 #4.
- After Peter Eisentraut asked where the module belonged #5 and Daniel Gustafsson supported core inclusion for pg_upgrade testing #6, Andrew confirmed the core destination #7 and posted a documented subclass patch with Windows and macOS handling, tested only on Linux #8.
- Alvaro Herrera examined the path handling and caught a stray brace in the library-path string #9, which Andrew corrected in the next patchset #10.
- When discussion resumed in March, Michael warned that an explicit subclass override list could miss newly added methods #12; following offline discussion, Andrew replaced subclassing and eval-generated wrappers with an install_path option and environment setup directly inside PostgresNode #13 #14.
- Dagfinn Ilmari Mannsåker proposed returning the desired environment for assignment to local %ENV #15, Alvaro suggested integrating PGHOST and PGPORT #17, and Andrew implemented a helper accepting arbitrary settings and undef-based deletion, simplifying PGAPPNAME handling #18 #19.
- Alvaro then requested that the helper always supply the node's host and port #20, which Andrew implemented in #21; Alvaro's final review requested comment cleanup and a more general helper name #22.
- Andrew committed #21 as b34ca595ab, retaining its functionality while renaming the helper to _get_env and adjusting comments and formatting.
- After the commit, Michael welcomed the opportunity to convert pg_upgrade testing to TAP #23, while Peter challenged the assumed bin/lib layout with common distribution paths #24; Michael argued that version-separated installations generally share a base path #25, leaving broader layout support unresolved with the submitted feature already landed.