Jan 2021

5 commits
Improve our heuristic for selecting PG_SYSROOT on macOS.
15 Jan 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.2+5 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #320 of 1 reviewer saw the final version

Matches the SDK-probing sequence in #32, with expanded comments and both version-detection expressions tightened to require the version number in the final directory component. Tom Lane confirms the polished landing in #38.

  • Sergey Shinderuksaw an earlier versionLLM analysis, 97% sureReported that the first workaround failed in #23 and confirmed the replacement patch worked in #37, before the committed regex tightening.
Move our p{read,write}v replacements into their own files.
13 Jan 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #191 of 1 reviewer saw the final version

Preserves the file split and retry-wrapper relocation from #19, adding the missing removal of unconditional pread.o/pwrite.o entries from src/port/Makefile and adjusting the fd.h declaration comment. These edits were requested in #20 and confirmed in #21.

  • Tom Lanesaw the final versionLLM analysis, 99% sureIn #20, identified the missing Makefile correction, proposed the declaration cleanup, and confirmed clean Big Sur and Catalina builds with those changes.
Don't use elog() in src/port/pwrite.c.
13 Jan 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements Thomas Munro's stated fix in #12: replace the backend-only elog(ERROR) in src/port/pwrite.c with an assertion to permit frontend linking, plus formatting cleanup. No preceding attached patch contains this corrective delta.

Use vectored I/O to fill new WAL segments.
11 Jan 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #90 of 2 reviewers saw the final version

Lands the complete WAL zero-fill component of the two-patch series in #9, separately from the portability component. The src/backend/access/transam/xlog.c diff differs only by renaming the called wrapper to pg_pwritev_with_retry().

  • Tom Lanesaw an earlier versiontrailerTested the WAL consumer on prairiedog and gaur and suggested a shared vector cap in #4, before the short-write handling and batch-size changes in #9.
  • Andres Freundsaw an earlier versiontrailerIdentified the need to handle partial writes in #6, before the retry wrapper and revised WAL error handling appeared in #9.
Provide pg_preadv() and pg_pwritev().
11 Jan 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #90 of 2 reviewers saw the final version

Lands the portability component of #9, leaving its WAL consumer to a separate commit. Beyond renaming pg_pwritev_retry(), it reworks completion detection from a precomputed byte goal to exhausted iovecs and adds the elog(ERROR) check later corrected in df10ac625c.

  • Tom Lanesaw an earlier versiontrailerRequested an isolated header in #2 and tested fallback implementations in #4, before the retry wrapper was introduced and subsequently reworked.
  • Andres Freundsaw an earlier versiontrailerReviewed header naming and proposed centralized partial-I/O handling in #6, before the retry implementation in #9 and its further commit-time changes.

Credits across 5 commits

Author
Thomas MunroLLM3
Tom LaneLLM1
Reviewer
Andres Freund2
Tom Lane2
Reported by
Tom Lane1
Committer
Thomas Munro4
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.