Mar 2021

1 commit
Add bit_count SQL function
23 Mar 2021Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #171 of 4 reviewers saw the final version

The commit preserves both bit_count overloads, bigint results, and regression coverage from #17; Peter Eisentraut announces committing with polishing in #18. It simplifies both C wrappers, replaces manual bit-byte length arithmetic with VARBITBYTES, renames the C entry points, revises documentation and examples, removes SET bytea_output, and bumps catversion.h.

  • Daniel Veritesaw an earlier versionLLM analysis, 100% sureIdentified possible result overflow in #2 and an overread-causing byte-length error in #8, both corrected before the later implementation cleanup.
  • Tom Lanesaw an earlier versionLLM analysis, 98% sureProposed replacing the confusing SQL name popcount with count_set_bits in #7, which #9 adopted before subsequent naming and implementation changes.
  • John Naylorsaw an earlier versionLLM analysis, 96% sureReported that the patch worked and questioned SET bytea_output in #15, which the commit removed while also simplifying the C wrappers.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
David Fetter1
Reviewer
Peter Eisentrautcommitter1
Committer
Peter Eisentraut1