fix typo in ReorderBufferProcessTXN
Hi
I found a possible typo in the comment of ReorderBufferProcessTXN().
* relmapper has no "historic" view, in contrast to normal
* the normal catalog during decoding. Thus repeated
Is there an extra ‘normal’ in the comment ?
in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding
Best regards,
houzj
Attachments:
0001-fix-typo.patchapplication/octet-stream; name=0001-fix-typo.patchDownload
From d49fc00bc852ee123b906605f3c166cf0d0a1c0a Mon Sep 17 00:00:00 2001
From: houzj <houzj.fnst@cn.fujitsu.com>
Date: Tue, 5 Jan 2021 08:48:18 +0800
Subject: [PATCH] fix typo
---
src/backend/replication/logical/reorderbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index df63b90..4f2cb12 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -2042,7 +2042,7 @@ ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
* Mapped catalog tuple without data, emitted while
* catalog table was in the process of being rewritten. We
* can fail to look up the relfilenode, because the
- * relmapper has no "historic" view, in contrast to normal
+ * relmapper has no "historic" view, in contrast to
* the normal catalog during decoding. Thus repeated
* rewrites can cause a lookup failure. That's OK because
* we do not decode catalog changes anyway. Normally such
--
2.7.2.windows.1
On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
Hi
I found a possible typo in the comment of ReorderBufferProcessTXN().
* relmapper has no "historic" view, in contrast to normal
* the normal catalog during decoding. Thus repeated
Is there an extra ‘normal’ in the comment ?
Yeah, I think so.
in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding
Looks good change to me.
Regards,
--
Masahiko Sawada
EnterpriseDB: https://www.enterprisedb.com/
On Tue, Jan 5, 2021 at 7:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding
Looks good change to me.
+1. I will push this in some time.
--
With Regards,
Amit Kapila.
On Tue, Jan 5, 2021 at 7:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Tue, Jan 5, 2021 at 7:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding
Looks good change to me.
+1. I will push this in some time.
Pushed.
--
With Regards,
Amit Kapila.