Jul 2021

2 commits
Avoid doing catalog lookups in postgres_fdw's conversion_error_callback.
6 Jul 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3REL_13_STABLE13.4+4 more
LLM analysis, 100% surelanded as postedfrom patchset #341 of 3 reviewers saw the final version

The code and regression-test changes match #34; the only substantive diff-text difference is joining two wrapped statements, as requested in #35. Tom Lane confirms that formatting adjustment and the push in #36, and the commit explicitly identifies him as the patch author.

  • Masahiko Sawadasaw an earlier versionLLM analysis, 100% sureIn #9, he reviewed #8 and proposed the helper rename and simpler generic-message fallback adopted in #10, before the later architectural rewrites.
  • Zhihong Yusaw an earlier versionLLM analysis, 99% sureIn #11, he identified wording errors in the postgres_fdw patch description that were corrected in #12, before the implementation was substantially rewritten.
  • Bharath Rupireddysaw the final versionLLM analysis, 100% sureHe reviewed Tom Lane's replacement implementation in #32 and approved #34 with the line-wrapping adjustment in #35 that was committed.
Don't try to print data type names in slot_store_error_callback().
2 Jul 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3REL_13_STABLE13.4+3 more
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #281 of 3 reviewers saw the final version

Takes the replication half of #28, retaining its worker.c simplification while additionally removing the LogicalRepTypMap cache, its update machinery and the apply_handle_type() update call. The commit credits Masahiko Sawada alongside sender Bharath Rupireddy, and #29 confirms the additional cleanup and that postgres_fdw remained pending.

  • Andres Freundsaw an earlier versionLLM analysis, 97% sureIn #22, he explained the critical-section failure path and supplied diagnostic changes and a subscription-test configuration that reproduced an assertion during review of #12, before type-name precomputation was abandoned.
  • Amit Kapilasaw an earlier versionLLM analysis, 88% sureHe requested concrete validation of the replication fix in #13 and proposed debugger-based reproduction in #19, which Bharath performed and reported in #20 before the later redesign.
  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Masahiko SawadaLLM1
Tom LaneLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.