Feb 2025

1 commit
Include schema/table publications even with exclude options in dump.
20 Feb 2025Amit Kapilamaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3811 of 1 reviewer saw the final version

The pg_dump.c changes exactly match #381, removing membership filters in getPublicationNamespaces and getPublicationTables. Committer edits simplify redundant test expectations and expand comments in src/bin/pg_dump/t/002_pg_dump.pl.

  • Amit Kapilasaw the final versiontrailerAmit supported the behavior in #378, requested explicit positive test expectations in #380, and reviewed the final version by committing it.

Oct - Nov 2021

3 commits
Rename some enums to use TABLE instead of REL.
9 Nov 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3613 of 3 reviewers saw the final version

The enum renames and parser error changes match #361; the commit additionally qualifies puballtables with its p alias in src/bin/psql/describe.c, as Peter proposed in #364.

  • Hou Zhijiesaw the final versiontrailerHou corrected the enum comment in #353, proposed shared CREATE/ALTER error wording in #359, and endorsed the revised patch in #363.
  • Peter Smithsaw the final versiontrailerPeter suggested clearer enum naming in #354, approved the revised patch in #362, and supplied the additional SQL alias correction in #364.
  • Amit Kapilasaw the final versioncommittercommitted the patch
Add tap tests for the schema publications.
29 Oct 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #3363 of 3 reviewers saw the final version

The changes to src/test/subscription/t/025_rep_changes_for_schema.pl exactly match the first patch in #336. The accompanying pg_publication_objects view was not included.

  • Greg Nancarrowsaw the final versiontrailerVignesh explicitly credits Greg's offline test comments as incorporated into #336, supporting final coverage of the revised tests carried forward from #333.
  • Hou Zhijiesaw the final versiontrailerHou requested standalone subscription tests in #150, and #336 explicitly credits his offline comments on the remaining test patch.
  • Amit Kapilasaw the final versiontrailerAmit requested separating potentially timing-sensitive TAP tests in #317 and confirmed committing the remaining test patch in #338.
Allow publishing the tables of schema.
27 Oct 2021Amit Kapilamaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #3333 of 9 reviewers saw the final version

The commit takes the first patch from #333, leaving its TAP tests and optional view behind. Differences are a catalog-version bump, formatting/comments and frontend allocation-function substitutions in src/bin/psql/describe.c.

  • Greg Nancarrowsaw the final versiontrailerGreg reviewed implementation, documentation and partition behavior throughout, then tested and approved the final partition-filter fix in #324, after which only light changes followed.
  • Masahiko Sawadasaw the final versiontrailerSawada reported cross-schema partition failures in #102 and completed a detailed review with only minor comments and an otherwise-positive assessment in #327.
  • Hou Zhijiesaw an earlier versiontrailerHou supplied cache, parser and partition fixes and approved PublicationRelInfo changes in #320, but the partition-filter logic changed afterward in #322.
  • Amit Kapilasaw the final versiontrailerAmit repeatedly reviewed and revised the implementation, approved the first patch in #334, and confirmed its commit in #335.
  • Haiying Tangsaw an earlier versiontrailerTang tested cache invalidation, permissions, dumps and partitions and approved the fixes in #316, before subsequent partition-filter logic changes.
  • Ajin Cheriansaw an earlier versiontrailerAjin applied the patch, reported passing make check and reviewed memory and index handling in #34 and #36, before the mixed-object redesign.
  • Rahila Syedsaw an earlier versiontrailerRahila reviewed the initial design, reported missing actual replication in #21, and identified SET TABLE publication-kind handling problems in #71.
  • Bharath Rupireddysaw an earlier versiontrailerBharath examined schema rename/drop behavior, future-table inclusion, unsupported relations and syntax in #4 and #5, before substantial implementation redesign.
  • Mark Dilgersaw an earlier versiontrailerMark demonstrated the schema-owner privilege bypass in #112 and clarified membership-removal permissions in #117, before mixed-object parsing and later partition changes.

Credits across 4 commits

Author
vignesh C4
Amit Kapila1
Hou, Zhijie1
tanghy.fnst@fujitsu.com1
Reviewer
Amit Kapilacommitter4
Hou, Zhijie3
Greg Nancarrow2
Ajin Cherian1
Bharath Rupireddy1
Mark Dilger1
Masahiko Sawada1
Peter Smith1
Rahila Syed1
tanghy.fnst@fujitsu.com1
Tested by
tanghy.fnst@fujitsu.com1
Reported by
Peter Smith1
Tom Lane1
Tomas Vondra1
Committer
Amit Kapila4