Fix a typo in SearchCatCache function comment

Started by Bharath Rupireddyabout 5 years ago3 messages
#1Bharath Rupireddy
bharath.rupireddyforpostgres@gmail.com
1 attachment(s)

Hi,

While reviewing the patch in [1]/messages/by-id/CAD21AoAwxbd-zXXUAeJ2FBRHr+=bfMUHoN7xJuXcwu1sFi1-sQ@mail.gmail.com, I found that SearchCatCache function
uses SearchCatCacheInternal as it's function name in the comment. It
looks like a typo, attaching a very small patch to correct it.

Thoughts?

[1]: /messages/by-id/CAD21AoAwxbd-zXXUAeJ2FBRHr+=bfMUHoN7xJuXcwu1sFi1-sQ@mail.gmail.com

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachments:

v1-0001-Use-correct-function-name-in-SearchCatCache-comme.patchapplication/octet-stream; name=v1-0001-Use-correct-function-name-in-SearchCatCache-comme.patchDownload
From bceb24e258188af43c46d9709874ea9e81b82cf1 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddy@enterprisedb.com>
Date: Tue, 12 Jan 2021 12:06:58 +0530
Subject: [PATCH v1] Use correct function name in SearchCatCache comment

SearchCatCache function comment uses SearchCatCacheInternal as the
function name. It looks like a typo. Correct it to use SearchCatCache
as the function name.
---
 src/backend/utils/cache/catcache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/cache/catcache.c b/src/backend/utils/cache/catcache.c
index ba95755867..fa2b49c676 100644
--- a/src/backend/utils/cache/catcache.c
+++ b/src/backend/utils/cache/catcache.c
@@ -1128,7 +1128,7 @@ IndexScanOK(CatCache *cache, ScanKey cur_skey)
 }
 
 /*
- *	SearchCatCacheInternal
+ *	SearchCatCache
  *
  *		This call searches a system cache for a tuple, opening the relation
  *		if necessary (on the first access to a particular cache).
-- 
2.25.1

#2Michael Paquier
michael@paquier.xyz
In reply to: Bharath Rupireddy (#1)
Re: Fix a typo in SearchCatCache function comment

On Tue, Jan 12, 2021 at 12:17:20PM +0530, Bharath Rupireddy wrote:

While reviewing the patch in [1], I found that SearchCatCache function
uses SearchCatCacheInternal as it's function name in the comment. It
looks like a typo, attaching a very small patch to correct it.

Good catch. I'll go fix it tomorrow if nobody objects.
--
Michael

#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: Fix a typo in SearchCatCache function comment

On Tue, Jan 12, 2021 at 04:21:18PM +0900, Michael Paquier wrote:

Good catch. I'll go fix it tomorrow if nobody objects.

And applied. Thanks!
--
Michael