Apr 2022

2 commits
Rewrite some RI code to avoid using SPI
7 Apr 2022Alvaro Herreramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #651 of 6 reviewers saw the final version

Matches the RI implementation patch in #65, with committer edits concentrated in ExecGetLeafPartitionForKey() in src/backend/executor/execPartition.c. These extend PartitionDirectory lifetime across traversal, reorder attribute matching, add empty-partition and interrupt checks, and revise comments and formatting.

  • Kyotaro Horiguchisaw an earlier versiontrailerIn #29, reviewed both patches and proposed removing obsolete PK query codes; substantial locking, permission, and snapshot changes followed.
  • Corey Huinkersaw an earlier versiontrailerReviewed naming, memory cleanup, locking and snapshots and repeatedly ran check-world, most recently on #58 in #59, before the later index-lookup and committed partition-traversal changes.
  • Li Japinsaw an earlier versiontrailerPosting as Japin Li in #7, reported the compiler fallthrough warning in #5, long before the permission, locking, and snapshot revisions.
  • Tom Lanesaw an earlier versiontrailerIdentified permission, security-context, locking, and snapshot concerns in #34 and #46, prompting substantial subsequent implementation changes.
  • Zhihong Yusaw an earlier versiontrailerReviewed assertions, null handling, cleanup, and partition indexing through #63, but the committed partition-traversal function received further moderate changes.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
Add isolation tests for snapshot behavior in ri_triggers.c
7 Apr 2022Alvaro Herreramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #652 of 3 reviewers saw the final version

The isolation-test patch in #65 matches all 186 added lines in src/test/isolation/specs/fk-snapshot.spec, its expected output, and isolation_schedule. It deliberately records the existing partitioned-table visibility bug for the following implementation commit to correct.

  • Tom Lanesaw an earlier versionLLM analysis, 90% sureRequested isolation coverage while reviewing #44 in #46 and supplied the visibility reproducer in #48 that Amit incorporated into the new tests.
  • Corey Huinkersaw the final versionLLM analysis, 99% sureReported successful check-world testing of #58 in #59, and its isolation-test patch remained unchanged through #65 and the commit.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Amit Langote2
Reviewer
Alvaro Herreracommitter2
Corey Huinker1
Japin Li1
Kyotaro Horiguchi1
Tom Lane1
Zhihong Yu1
Committer
Alvaro Herrera2