[patch] Help information for pg_dump
Hi all
After executing command [pg_dump -?], some help information is as follows.
pg_dump -?
-----------------------------------------------------------------
-N, --exclude-schema=PATTERN do NOT dump the specified schema(s) ※
-T, --exclude-table=PATTERN do NOT dump the specified table(s) ※
-x, --no-privileges do not dump privileges (grant/revoke)
--exclude-table-data=PATTERN do NOT dump data for the specified table(s) ※
--no-comments do not dump comments
--no-publications do not dump publications
--no-security-labels do not dump security label assignments
--no-subscriptions do not dump subscriptions
--no-synchronized-snapshots do not use synchronized snapshots in parallel jobs
--no-tablespaces do not dump tablespace assignments
--no-unlogged-table-data do not dump unlogged table data
--------------------------------------------------------------------
I think it would be better to change [do NOT dump] to [do not dump].
Here is a patch.
Best Regards!
Attachments:
pg_dump.patchapplication/octet-stream; name=pg_dump.patchDownload
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 798d145..36d7419 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -1021,13 +1021,13 @@ help(const char *progname)
printf(_(" -C, --create include commands to create database in dump\n"));
printf(_(" -E, --encoding=ENCODING dump the data in encoding ENCODING\n"));
printf(_(" -n, --schema=PATTERN dump the specified schema(s) only\n"));
- printf(_(" -N, --exclude-schema=PATTERN do NOT dump the specified schema(s)\n"));
+ printf(_(" -N, --exclude-schema=PATTERN do not dump the specified schema(s)\n"));
printf(_(" -O, --no-owner skip restoration of object ownership in\n"
" plain-text format\n"));
printf(_(" -s, --schema-only dump only the schema, no data\n"));
printf(_(" -S, --superuser=NAME superuser user name to use in plain-text format\n"));
printf(_(" -t, --table=PATTERN dump the specified table(s) only\n"));
- printf(_(" -T, --exclude-table=PATTERN do NOT dump the specified table(s)\n"));
+ printf(_(" -T, --exclude-table=PATTERN do not dump the specified table(s)\n"));
printf(_(" -x, --no-privileges do not dump privileges (grant/revoke)\n"));
printf(_(" --binary-upgrade for use by upgrade utilities only\n"));
printf(_(" --column-inserts dump data as INSERT commands with column names\n"));
@@ -1035,7 +1035,7 @@ help(const char *progname)
printf(_(" --disable-triggers disable triggers during data-only restore\n"));
printf(_(" --enable-row-security enable row security (dump only content user has\n"
" access to)\n"));
- printf(_(" --exclude-table-data=PATTERN do NOT dump data for the specified table(s)\n"));
+ printf(_(" --exclude-table-data=PATTERN do not dump data for the specified table(s)\n"));
printf(_(" --extra-float-digits=NUM override default setting for extra_float_digits\n"));
printf(_(" --if-exists use IF EXISTS when dropping objects\n"));
printf(_(" --include-foreign-data=PATTERN\n"
On Tue, Jan 19, 2021 at 9:07 AM Zhang, Jie <zhangjie2@cn.fujitsu.com> wrote:
Hi all
After executing command [pg_dump -?], some help information is as follows.
pg_dump -?
-----------------------------------------------------------------
-N, --exclude-schema=PATTERN do NOT dump the specified schema(s) ※
-T, --exclude-table=PATTERN do NOT dump the specified table(s) ※
-x, --no-privileges do not dump privileges (grant/revoke)
--exclude-table-data=PATTERN do NOT dump data for the specified table(s) ※
--no-comments do not dump comments
--no-publications do not dump publications
--no-security-labels do not dump security label assignments
--no-subscriptions do not dump subscriptions
--no-synchronized-snapshots do not use synchronized snapshots in parallel jobs
--no-tablespaces do not dump tablespace assignments
--no-unlogged-table-data do not dump unlogged table data
--------------------------------------------------------------------I think it would be better to change [do NOT dump] to [do not dump].
Here is a patch.
+1. Looks like SQL keywords are mentioned in capital letters in both
pg_dump and pg_dumpall cases, so changing "do NOT" to "do not" seems
okay to me.
Patch LGTM.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
On Tue, Jan 19, 2021 at 11:24 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
On Tue, Jan 19, 2021 at 9:07 AM Zhang, Jie <zhangjie2@cn.fujitsu.com> wrote:
Hi all
After executing command [pg_dump -?], some help information is as follows.
pg_dump -?
-----------------------------------------------------------------
-N, --exclude-schema=PATTERN do NOT dump the specified schema(s) ※
-T, --exclude-table=PATTERN do NOT dump the specified table(s) ※
-x, --no-privileges do not dump privileges (grant/revoke)
--exclude-table-data=PATTERN do NOT dump data for the specified table(s) ※
--no-comments do not dump comments
--no-publications do not dump publications
--no-security-labels do not dump security label assignments
--no-subscriptions do not dump subscriptions
--no-synchronized-snapshots do not use synchronized snapshots in parallel jobs
--no-tablespaces do not dump tablespace assignments
--no-unlogged-table-data do not dump unlogged table data
--------------------------------------------------------------------I think it would be better to change [do NOT dump] to [do not dump].
Here is a patch.
+1. Looks like SQL keywords are mentioned in capital letters in both
pg_dump and pg_dumpall cases, so changing "do NOT" to "do not" seems
okay to me.Patch LGTM.
Also "do NOT" is inconsistent with the other message where we are
saying "do not" so +1
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com