Jan 2021

4 commits
pgbench: Remove dead code
28 Jan 2021Alvaro Herreramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.2+5 more
LLM analysis, 100% surelanded as postedfrom patchset #131 of 1 reviewer saw the final version

The commit deletes exactly the CONNECTION_BAD block in src/bin/pgbench/pgbench.c proposed in #13; only diff context differs. Alvaro confirms the push in #15.

  • Tom Lanesaw the final versiontrailerTom confirms in #14 that the block is unreachable and explains that he missed it because it was separated from the PQconnectdbParams call.
Report the true database name on connection errors
26 Jan 2021Alvaro HerreraREL_13_STABLE13.2REL_12_STABLE12.6REL_11_STABLE11.11REL_10_STABLE10.16REL9_6_STABLE9.6.21REL9_5_STABLE9.5.25
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #8

The commit preserves the PQdb(conn) replacement from #8 and extends it to oid2name, vacuumlo, pg_dumpall and another pgbench error site, adding NULL guards at the additional sites. Its message specifies branches 9.5 through 13, and #13 confirms the push.

Avoid redundantly prefixing PQerrorMessage for a connection failure.
22 Jan 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #12

All added and removed lines across all 21 files match #12, including prefix removal, documentation examples, ECPG output and regression expectations.

Improve new wording of libpq's connection failure messages.
21 Jan 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The commit implements the connection-to-server wording proposed in #4 and #11, renames the helper in src/interfaces/libpq/fe-connect.c and adjusts test output and filtering. No attachment contains this change, and Tom announces its completion in #12.

Credits across 4 commits

Author
Alvaro HerreraLLM2
Tom LaneLLM1
Reviewer
Tom Lane1
Reported by
Robert Haas1
Committer
Alvaro Herrera2
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.