mkid reference
Hi!
in src/tools/make_diff/ there is a reference:
"If I use mkid (from ftp.postgreSQL.org), I can do:"
There is no such thing on our download site, and I can't find what it
even was at one point.
Was this part of some other package, since removed?
And maybe even more interestnig -- is there a point to this whole
make_diff directory at all in these days of git? Or should we just
remove it rather than try to fix it?
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
On 22 Jan 2021, at 12:56, Magnus Hagander <magnus@hagander.net> wrote:
And maybe even more interestnig -- is there a point to this whole
make_diff directory at all in these days of git? Or should we just
remove it rather than try to fix it?
There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
If anything, it seems better replaced by extended documentation on the existing
wiki article [0]https://wiki.postgresql.org/wiki/Working_with_Git on how to use "git format-patch".
--
Daniel Gustafsson https://vmware.com/
Le ven. 22 janv. 2021 à 20:33, Daniel Gustafsson <daniel@yesql.se> a écrit :
On 22 Jan 2021, at 12:56, Magnus Hagander <magnus@hagander.net> wrote:
And maybe even more interestnig -- is there a point to this whole
make_diff directory at all in these days of git? Or should we just
remove it rather than try to fix it?There's also src/tools/make_mkid which use this mkid tool. +1 for
removing.
If anything, it seems better replaced by extended documentation on the
existing
wiki article [0] on how to use "git format-patch".
definitely +1
Show quoted text
Daniel Gustafsson <daniel@yesql.se> writes:
On 22 Jan 2021, at 12:56, Magnus Hagander <magnus@hagander.net> wrote:
And maybe even more interestnig -- is there a point to this whole
make_diff directory at all in these days of git? Or should we just
remove it rather than try to fix it?
There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
If anything, it seems better replaced by extended documentation on the existing
wiki article [0] on how to use "git format-patch".
I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags and
make_etags in there, I don't have a problem with leaving make_mkid.
make_diff, on the other hand, certainly looks like technology whose
time has passed. I wonder about pgtest, too.
regards, tom lane
On Fri, Jan 22, 2021 at 7:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Daniel Gustafsson <daniel@yesql.se> writes:
On 22 Jan 2021, at 12:56, Magnus Hagander <magnus@hagander.net> wrote:
And maybe even more interestnig -- is there a point to this whole
make_diff directory at all in these days of git? Or should we just
remove it rather than try to fix it?There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
If anything, it seems better replaced by extended documentation on the existing
wiki article [0] on how to use "git format-patch".I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags and
make_etags in there, I don't have a problem with leaving make_mkid.make_diff, on the other hand, certainly looks like technology whose
time has passed. I wonder about pgtest, too.
I'll go kill make_diff then -- quicker than fixing the docs of it.
As for pgtest, that one looks a bit interesting as well -- but it's
been patched on as late as 9.5 and in 2018, so it seems at least Bruce
uses it :)
While at it, what point is "codelines" adding?
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
On Fri, Jan 22, 2021 at 01:07:36PM -0500, Tom Lane wrote:
There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
If anything, it seems better replaced by extended documentation on the existing
wiki article [0] on how to use "git format-patch".I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags and
Yes, I do still use it, so I thought having a script to generate its
index files might be helpful to someone.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Sun, Jan 24, 2021 at 02:20:58PM +0100, Magnus Hagander wrote:
I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags and
make_etags in there, I don't have a problem with leaving make_mkid.make_diff, on the other hand, certainly looks like technology whose
time has passed. I wonder about pgtest, too.I'll go kill make_diff then -- quicker than fixing the docs of it.
As for pgtest, that one looks a bit interesting as well -- but it's
been patched on as late as 9.5 and in 2018, so it seems at least Bruce
uses it :)
Yes, that is how I noticed the ecpg/preproc.y warning this past weekend.
While at it, what point is "codelines" adding?
That is the script I use to generate code line counts when comparing
releases. I thought it should be in the tree so others can reproduce my
numbers.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Mon, Jan 25, 2021 at 4:38 PM Bruce Momjian <bruce@momjian.us> wrote:
On Fri, Jan 22, 2021 at 01:07:36PM -0500, Tom Lane wrote:
There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
If anything, it seems better replaced by extended documentation on the existing
wiki article [0] on how to use "git format-patch".I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags andYes, I do still use it, so I thought having a script to generate its
index files might be helpful to someone.
Where do you actually get it? The old docs (now removed) suggested
getting it off ftp.postgresql.org...
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
On Tue, Jan 26, 2021 at 05:03:30PM +0100, Magnus Hagander wrote:
On Mon, Jan 25, 2021 at 4:38 PM Bruce Momjian <bruce@momjian.us> wrote:
On Fri, Jan 22, 2021 at 01:07:36PM -0500, Tom Lane wrote:
There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
If anything, it seems better replaced by extended documentation on the existing
wiki article [0] on how to use "git format-patch".I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags andYes, I do still use it, so I thought having a script to generate its
index files might be helpful to someone.Where do you actually get it? The old docs (now removed) suggested
getting it off ftp.postgresql.org...
Not sure why it was on our ftp site, since it is a GNU download:
https://www.gnu.org/software/idutils/
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
On Tue, Jan 26, 2021 at 6:58 PM Bruce Momjian <bruce@momjian.us> wrote:
On Tue, Jan 26, 2021 at 05:03:30PM +0100, Magnus Hagander wrote:
On Mon, Jan 25, 2021 at 4:38 PM Bruce Momjian <bruce@momjian.us> wrote:
On Fri, Jan 22, 2021 at 01:07:36PM -0500, Tom Lane wrote:
There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
If anything, it seems better replaced by extended documentation on the existing
wiki article [0] on how to use "git format-patch".I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags andYes, I do still use it, so I thought having a script to generate its
index files might be helpful to someone.Where do you actually get it? The old docs (now removed) suggested
getting it off ftp.postgresql.org...Not sure why it was on our ftp site, since it is a GNU download:
Ah, good. Then at least we now have it in the list archives for
reference if somebody else searches for it :)
And no, it wasn't actually on our ftp server. But it might have been
at some point far far in the past...
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
On Mon, Jan 25, 2021 at 4:40 PM Bruce Momjian <bruce@momjian.us> wrote:
On Sun, Jan 24, 2021 at 02:20:58PM +0100, Magnus Hagander wrote:
While at it, what point is "codelines" adding?
That is the script I use to generate code line counts when comparing
releases. I thought it should be in the tree so others can reproduce my
numbers.
Not that it particularly matters to keep it, but wouldn't something
like cloc give a much better number?
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
On Tue, Jan 26, 2021 at 10:19:44PM +0100, Magnus Hagander wrote:
On Mon, Jan 25, 2021 at 4:40 PM Bruce Momjian <bruce@momjian.us> wrote:
On Sun, Jan 24, 2021 at 02:20:58PM +0100, Magnus Hagander wrote:
While at it, what point is "codelines" adding?
That is the script I use to generate code line counts when comparing
releases. I thought it should be in the tree so others can reproduce my
numbers.Not that it particularly matters to keep it, but wouldn't something
like cloc give a much better number?
Yes, we could, but we didn't really have any criteria on exactly what to
count, so I just counted physical lines.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee