model-writtenrun 7620 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- James Hilliard posted an inline v3 fix for builds that detected preadv/pwritev in a newer macOS SDK but crashed on an older deployment target, replacing function-symbol probes with AC_CHECK_DECLS and enabling -Werror=unguarded-availability-new for C and C++ #1.
- James explained that the standard declaration probes addressed earlier maintainability objections to custom compile probes, then supplied the indexed attachment after David Steele requested one for CI #2 #3 #4.
- Thomas Munro inspected successful CI runs across four operating systems, confirmed that only the clang-based systems enabled the new flags, and requested alphabetized Windows configuration definitions; James accepted that cleanup #5 #6.
- Tom Lane objected to changing feature-probing methods whenever Apple added APIs and preferred giving existing SDK-selection improvements time to prove themselves, while James argued that those heuristics could not reliably enforce deployment-target availability #8 #12 #13.
- Sandeep Thakkar subsequently reported the same failure with PostgreSQL 14 beta1 binaries targeting macOS 10.15, and Dave Page explained that building older-target binaries with newer SDKs was essential to the PostgreSQL and pgAdmin installers #14 #15.
- Thomas suggested a manual configure control to disable preadv/pwritev as a narrower alternative, while Peter Eisentraut supported declaration-based probing and explained why library-symbol checks already failed to capture several forms of API usability #17 #18.
- Tom came to regard the submitted patch as a reasonable deployment-target fix but proposed runtime symbol lookup to use native vectored I/O whenever available; James suggested an availability-check approach, and Tom preferred a cached function pointer with an emulation fallback #19 #20 #21.
- Peter questioned the practical benefit of runtime detection, and Thomas explained that these functions arrived in macOS 11 and currently offered little benefit beyond avoiding an extra seek while initializing WAL files #22 #23.
- In the final message, Tom dropped the runtime-probe proposal and accepted switching to declaration checks; he subsequently committed #4 with light comment and ordering cleanups as f014b1b9bb, completing the submitted fix #24.