protect pg_stat_statements_info() for being used without the library loaded

Started by Jaime Casanovaabout 5 years ago5 messageshackers
Jump to latest
#1Jaime Casanova
jcasanov@systemguards.com.ec

Hi,

Attached is a small patch for ${subject}

--
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL

Attachments:

fix_pg_stat_statements_info.patchtext/x-patch; charset=US-ASCII; name=fix_pg_stat_statements_info.patchDownload+5-0
#2Julien Rouhaud
rjuju123@gmail.com
In reply to: Jaime Casanova (#1)
Re: protect pg_stat_statements_info() for being used without the library loaded

On Thu, Jan 28, 2021 at 3:53 AM Jaime Casanova
<jcasanov@systemguards.com.ec> wrote:

Hi,

Attached is a small patch for ${subject}

Good catch, and patch looks good to me.

#3Michael Paquier
michael@paquier.xyz
In reply to: Julien Rouhaud (#2)
Re: protect pg_stat_statements_info() for being used without the library loaded

On Thu, Jan 28, 2021 at 08:49:54AM +0800, Julien Rouhaud wrote:

Good catch, and patch looks good to me.

This crashes the server, cash. Looking at all the other modules in
the tree, I am not seeing any other hole. This is new as of 9fbc3f3,
and I will apply it on HEAD.
--
Michael

#4Fujii Masao
masao.fujii@gmail.com
In reply to: Michael Paquier (#3)
Re: protect pg_stat_statements_info() for being used without the library loaded

On 2021/01/28 15:42, Michael Paquier wrote:

On Thu, Jan 28, 2021 at 08:49:54AM +0800, Julien Rouhaud wrote:

Good catch, and patch looks good to me.

This crashes the server, cash. Looking at all the other modules in
the tree, I am not seeing any other hole. This is new as of 9fbc3f3,
and I will apply it on HEAD.

Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

#5Michael Paquier
michael@paquier.xyz
In reply to: Fujii Masao (#4)
Re: protect pg_stat_statements_info() for being used without the library loaded

On Thu, Jan 28, 2021 at 03:53:54PM +0900, Fujii Masao wrote:

Thanks!

No problem. Applied as of bca96dd.
--
Michael