Apr 2021

2 commits
doc: Review for "Allow TRUNCATE command to truncate foreign tables".
27 Apr 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1133 of 3 reviewers saw the final version

Takes the documentation component of the two-patch submission #113, coauthored by Justin Pryzby and Fujii Masao; its only additional edit restores “for instance” in doc/src/sgml/ref/truncate.sgml as discussed in #115.

  • Bharath Rupireddysaw the final versiontrailerReviewed successive documentation versions and proposed a final line-layout adjustment in #114, after which only light wording changes followed.
  • Justin Pryzbysaw the final versiontrailerReviewed Fujii's revision of his documentation patch in #104 and clarified how to describe default identity behavior in #107.
  • Fujii Masaosaw the final versiontrailerReviewed and revised Justin's documentation in #77 and #81, then made the final wording adjustment and committed it.
Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper.
27 Apr 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1134 of 4 reviewers saw the final version

Exactly matches the ONLY-removal component of #113, including its stable patch ID; the separate documentation cleanup was committed afterward. It removes rels_extra and context constants across tablecmds.c, worker.c and the FDW API and updates postgres_fdw tests and documentation.

  • Bharath Rupireddysaw the final versiontrailerReviewed code layout, regression behavior and ONLY documentation in #99 and subsequent replies, and reviewed both final patches in #114.
  • Kyotaro Horiguchisaw the final versiontrailerReviewed the removal patch and supplied the missing child-table test data in #98, after which only test and documentation refinements followed.
  • Justin Pryzbysaw the final versiontrailerIdentified wording, spacing and spelling corrections in the ONLY-removal documentation in #104, which were incorporated in the final patch.
  • Zhihong Yusaw the final versiontrailerReviewed the wording introducing the ONLY option in #108, with only light documentation changes afterward.

Apr 2021

2 commits
Support tab-complete for TRUNCATE on foreign tables.
12 Apr 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #701 of 1 reviewer saw the final version

The diff and stable patch ID match #70: src/bin/psql/tab-complete.c adds Query_for_list_of_truncatables and uses it for the three TRUNCATE completion cases.

  • Bharath Rupireddysaw the final versiontrailerReported that the tab-completion patch worked as expected in #72 before it was committed.
Allow TRUNCATE command to truncate foreign tables.
8 Apr 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: TRUNCATE on foreign tables (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #651 of 10 reviewers saw the final version

The final patch attached by the committer in #65 exactly matches the commit diff and stable patch ID; the commit credits Kazutaka Onishi and Kohei KaiGai, with Fujii's edits. This April 2021 source is newer than all listed submissions in thread #41753, whose latest patch dates to March 2020.

  • Bharath Rupireddysaw an earlier versiontrailerReviewed tests, hash cleanup, connection timing and SQL helper reuse through #54, before Fujii changed error reporting, logical-logging checks and context constants.
  • Michael Paquiersaw an earlier versiontrailerArgued against generating core WAL for foreign-table truncation in #21, before that behavior and later implementation details were revised.
  • Zhihong Yusaw an earlier versiontrailerReviewed option-loop exits, naming, comments and hash cleanup in #2, #35 and #36, before subsequent logic changes.
  • Alvaro Herrerano review foundtrailerThe commit credits this reviewer, but no review activity by this person appears in the supplied thread.
  • Stephen Frostno review foundtrailerEarlier design advice is quoted in #57, but Stephen sent no review message in the supplied thread.
  • Ashutosh Bapatsaw an earlier versiontrailerQuestioned truncatable-option semantics and use cases in #4 and subsequent discussion, before the implementation's later revisions.
  • Amit Langotesaw an earlier versiontrailerRan check-world and diagnosed missing partition entries in relids_extra in #13, before that fix and later implementation changes.
  • Daniel Gustafssonno review foundtrailerThe commit credits this reviewer, but no review activity by this person appears in the supplied thread.
  • Ibrar Ahmedsaw an earlier versiontrailerInspected and repaired the expected-output conflict in #12, before partition handling and other logic were revised.
  • Fujii Masaosaw the final versiontrailerReviewed documentation, WAL generation and ONLY semantics, prepared the final revisions, and committed the exact version recorded in #65.

Credits across 4 commits

Author
Fujii Masao3
Justin Pryzby1
KaiGai Kohei1
Kazutaka Onishi1
slightly modified by Fujii Masao1
Reviewer
Bharath Rupireddy4
Fujii Masao2
Justin Pryzby2
Zhihong Yu2
Alvaro Herrera1
Amit Langote1
Ashutosh Bapat1
Daniel Gustafsson1
Ibrar Ahmed1
Kyotaro Horiguchi1
Michael Paquier1
Stephen Frost1
Committer
Fujii Masao4