Jul 2022

1 commit
Fix minor memory leaks in psql's tab completion.
22 Jul 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta3
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #531 of 1 reviewer saw the final version

Includes both frees from #53 unchanged in src/bin/psql/tab-complete.c and adds cleanup of left_literal in src/fe_utils/string_utils.c. Tom Lane explains the additional Valgrind-discovered leak in #54.

  • Tom Lanesaw the final versioncommittercommitted the patch

Jan - Feb 2022

3 commits
Further tweaks for psql's new tab-completion logic.
9 Feb 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 90% surewritten from the discussion, no matching patch

Implements the reconsideration in #52, returning to unconditional keyword case adjustment originally proposed in #47, and adds verbatim handling and tests for qualified GUC names. No attachment contains this combined follow-up against the landed compromise.

Treat case of tab-completion keywords a bit more carefully.
1 Feb 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #501 of 1 reviewer saw the final version

Combines the keyword-list and SHOW SESSION changes from #50 with the conditional case-adjustment implementation and tests from #49. Additional edits rename num_other to num_query_other and clarify readline quoting limitations, with the push confirmed in #51.

  • Tom Lanesaw the final versioncommittercommitted the patch
psql: improve tab-complete's handling of variant SQL names.
30 Jan 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #430 of 5 reviewers saw the final version

Reconstructing all five patches in #43 shows the commit retains their implementation but additionally converts text-search objects to SchemaQuery, renames completion_info interfaces to completion_ref, adds a keyword test, and expands doc/src/sgml/ref/psql-ref.sgml.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 99% sureReviewed query-completion scope, test coverage, helper design, encoding behavior, and enum case sensitivity in #6, #10, #23, #25, #30, and #34, before the substantial rewrite.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 99% sureProposed the initial query-specific alternative in #3 and identified incorrect identifier case adjustment and schema-qualified quoting behavior in #14 and #16, before the rewrite.
  • David Zhangsaw an earlier versionLLM analysis, 100% sureTested #7, reported incomplete uppercase-table completion, and requested tests in #8, prompting fixes before the later rewrite.
  • Peter Smithsaw an earlier versionLLM analysis, 100% sureTested #11 and identified memory leaks, an unnecessary NULL check, unrelated cleanup, and test issues in #12, before the substantial rewrite.
  • Japin Lisaw an earlier versionLLM analysis, 100% sureIdentified the incorrect helper name in the comment of #27 in #28, which was corrected before the later rewrite.

Credits across 4 commits

Author
Dagfinn Ilmari MannsåkerLLM1
tanghy.fnst@fujitsu.comLLM1
Tom LaneLLM1
Reviewer
Tom Lanecommitter2
Committer
Tom Lane4

N LLM means N of the credits come from LLM analysis, not from commit trailers.