Feb - Mar 2021

10 commits
Suppress unnecessary regex subre nodes in a couple more cases.
2 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 97% surewritten from the discussion, no matching patch

This unattached follow-up extends the subre-reduction work in #7 and #9. Its new parseqatom() cases replace capture-free/backref-free iteration with a plain DFA and collapse another concatenation; neither appears in the attached patches.

Improve memory management in regex compiler.
26 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #330 of 1 reviewer saw the final version

Retains the NFA-wide pools and batched states from #33, but adds lastsbused/lastabused allocation cursors and changearcsource() to relink arcs in moveouts(). The latter improvement was proposed in #34.

  • Joel Jacobsonsaw an earlier versionLLM analysis, 100% sureJoel tested #33 across 3,253,889 cases and reported unchanged results and a 29% speedup in #35, before the additional allocation and arc-relinking changes landed.
Allow complemented character class escapes within regex brackets.
25 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: Bizarre behavior of \w in a regular expression bracket construct (part of a posted patchset)
Suppress compiler warning in new regex match-all detection code.
23 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements the inline solution proposed in #25 and chosen in #29: replace the depth assertion in checkmatchall_recurse() with an always-on negative-depth check, adding REG_ASSERT error reporting. Andres's warning report in #23 is credited as reporting, not review of this fix.

Avoid generating extra subre tree nodes for capturing parentheses.
21 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

Lands the capture-annotation member of the five-patch series in #9, preserving its implementation. The only additional changes document re_info flags in src/include/regex/regex.h.

  • Joel Jacobsonsaw the final versionLLM analysis, 100% sureJoel reported no semantic differences across 3,254,769 cases with the five-patch series in #10, and the commit explicitly credits his review.
Convert regex engine's subre tree from binary to N-ary style.
21 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

Lands the N-ary subre-tree member of #9. Compared with that attachment, the only added hunk prints the second child's identifier in stdump() in src/backend/regex/regcomp.c.

  • Joel Jacobsonsaw the final versionLLM analysis, 100% sureJoel tested the four-patch version in #8 and the final five-patch version in #10, and the commit explicitly credits his review.
Fix regex engine to suppress useless concatenation sub-REs.
20 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

The src/backend/regex/regcomp.c diff exactly matches the redundant-concatenation member of #9, apart from patch metadata. It lands that member separately from the other four series components.

  • Joel Jacobsonsaw the final versionLLM analysis, 100% sureJoel reported successful correctness and performance tests in #8 and #10, and the commit explicitly credits his review.
Recognize "match-all" NFAs within the regex engine.
20 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

Exactly matches the match-all NFA member of #9, apart from patch metadata, including pseudocolor validation and executor length shortcuts. It is one component of that five-patch submission.

  • Joel Jacobsonsaw the final versionLLM analysis, 100% sureJoel found capture regressions in #2, verified their correction in #5, and tested subsequent versions through #10; the commit explicitly credits his review.
Invent "rainbow" arcs within the regex engine.
20 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

Exactly matches the RAINBOW-arc member of #9, apart from patch metadata, including regex export and contrib/pg_trgm adaptations. It lands separately from the other members of the submission.

  • Joel Jacobsonsaw the final versionLLM analysis, 100% sureJoel tested the RAINBOW changes throughout the series in #2, #5, #8, and #10, and the commit explicitly credits his review.
Make some minor improvements in the regex code.
17 Feb 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #70 of 1 reviewer saw the final version

Extracts the compact() error return and lookaround regression tests present in #7, adding previously unattached parseqatom() assertion fixes and regexec.c debugging improvements. Tom explicitly identifies this preparatory split in #9.

  • Joel Jacobsonsaw an earlier versionLLM analysis, 86% sureJoel tested the earlier submissions containing the extracted changes in #2, #5, and #8, before the additional assertion fixes and debugging changes were committed.

Credits across 10 commits

Author
Tom LaneLLM8
Committer
Tom Lane10

N LLM means N of the credits come from LLM analysis, not from commit trailers.