Jun 2021

1 commit
libpq: Fix SNI host handling
8 Jun 2021Peter Eisentrautmaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 100% suremodified before commitlight changesfrom patchset #211 of 1 reviewer saw the final version

The commit matches the host-selection and NULL/empty guards in #21, except that it removes the redundant SSL_CTX_free(SSL_context) call in src/interfaces/libpq/fe-secure-openssl.c. Michael Paquier identified that no-op in #23, and Peter confirmed incorporating it in #24.

  • Michael Paquiersaw the final versiontrailerMichael tested #21 and proposed removing the redundant SSL_CTX_free() call in #23, which was the only subsequent code change.

Apr 2021

1 commit
libpq: Set Server Name Indication (SNI) for SSL connections
7 Apr 2021Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #150 of 5 reviewers saw the final version

All five changed files match #15 modulo rebase context, including unrelated additions to the postgres_fdw valid-options list; the SNI implementation and documentation are unchanged. Peter confirmed committing that version in #16.

  • Matthias van de Meentsaw an earlier versionLLM analysis, 100% sureMatthias identified the rejection of valid digit-prefixed hostnames in #2, prompting the predicate fix in #6, before the connection-option changes in #15.
  • Jacob Championsaw an earlier versionLLM analysis, 96% sureJacob requested a privacy toggle after reviewing the proposed behavior in #5, and #15 added that option while choosing a different default.
  • Greg Starksaw an earlier versionLLM analysis, 87% sureGreg questioned IPv6 handling and quoted the filtering predicate in #12, leading to clarification before the connection-option changes in #15.
  • Stephen Frostsaw an earlier versionLLM analysis, 97% sureStephen requested documentation of the PostgreSQL-aware proxy requirement and a way to disable SNI in #11, both incorporated into #15.
  • Magnus Hagandersaw an earlier versionLLM analysis, 96% sureMagnus explained why the colon check handles IPv6 and requested clearer comments in #14, before #15 added the connection option and explicitly named IPv4 and IPv6.

Credits across 2 commits

Author
Peter EisentrautLLM2
Reviewer
Michael Paquier1
Reported by
Jacob Champion1
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.