May 2022

1 commit
Remove debug messages from tuplesort_sort_memtuples()
23 May 2022John Naylormaster15beta2REL_19_STABLE15beta2REL_18_STABLE15beta2REL_17_STABLE15beta2REL_16_STABLE15beta2REL_15_STABLE15beta2
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

The commit removes five DEBUG1 calls from tuplesort_sort_memtuples(), following the report at #81 and agreement at #82, #83 and #84. No indexed attachment proposes this removal; #85 confirms completion.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureReported the unexpectedly noisy DEBUG1 output and proposed removing it in #81, which directly prompted the committed cleanup.
  • Peter Geoghegansaw the final versionLLM analysis, 97% sureConfirmed in #82 that DEBUG1 was too chatty and discussed reducing the messages' visibility before their removal.
  • Tom Lanesaw the final versionLLM analysis, 100% sureExplained that the messages lacked useful context and explicitly supported removing them in #83.

Apr 2022

1 commit
Fix performance regression in tuplesort specializations
22 Apr 2022David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #741 of 1 reviewer saw the final version

The commit implements the onlyKey checks from #74 in all three specialized comparators, splitting the combined conditions into equivalent sequential returns and revising comments. David confirms the landing in #78.

  • John Naylorsaw the final versiontrailerBenchmarked both approaches in #70, questioned flag initialization in #73, and retested and endorsed the final onlyKey version in #75.

Apr 2022

2 commits
Fix tuplesort optimization for CLUSTER-on-expression.
3 Apr 2022Thomas Munromaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #591 of 1 reviewer saw the final version

The commit takes the haveDatum1 fix from #59, adjusts its explanatory comment, and also replaces the equivalent leading-attribute test in comparetup_cluster() with haveDatum1. The author describes the landing as having a minor tweak in #61.

  • Andres Freundsaw the final versiontrailerRequested a consolidated specialization guard in #58 and endorsed the revised explicit initialization scheme in #60.
Specialize tuplesort routines for different kinds of abbreviated keys
2 Apr 2022John Naylormaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #341 of 2 reviewers saw the final version

All added and removed code matches #34, including the three tuplesort specializations and expanded datatype consumers. John announced an as-is landing in #45 and confirmed it in #47.

  • Peter Geoghegansaw an earlier versionLLM analysis, 98% sureRequested coverage of UUID, macaddr and inet in #31, which Thomas added in #34; the commit also explicitly credits Peter's review.
  • John Naylorsaw the final versioncommittercommitted the patch

Jan 2022

1 commit
Fix missing undefine in sort_template.h
31 Jan 2022John Naylormaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 94% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The one-line addition of #undef ST_CHECK_FOR_INTERRUPTS matches the missing-undef correction identified in #38, selected for commitment in #42, and confirmed committed in #43. It belonged to Thomas's unindexed expanded tarball series, not any of the 13 indexed patchsets, and the commit explicitly credits Thomas.

  • John Naylorsaw the final versioncommittercommitted the patch

Mar 2021

4 commits
Specialize checkpointer sort functions.
12 Mar 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The bufmgr.c changes exactly match #4, including sort_checkpoint_bufferids(), sort_pending_writebacks(), and typed inline comparators.

  • Andres Freundsaw the final versiontrailerReported substantial checkpointer benchmark gains in #2 and explicitly approved the attached specialization in #5.
Use sort_template.h for qsort() and qsort_arg().
3 Mar 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

This lands the second component of #1 unchanged, replacing duplicated implementations in src/port/qsort.c and src/port/qsort_arg.c with template instantiations. The partial verdict reflects series scope.

  • Daniel Gustafssonsaw the final versiontrailerReported successful tests and reviewed the port/qsort.c documentation in #3, with Thomas explaining the retained minimal wrapper in #4.
Use sort_template.h for qsort_tuple() and qsort_ssup().
3 Mar 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

This lands the third component of #1 unchanged: template-based tuple sorts and removal of the Perl generator and its build integration. The partial verdict reflects its being one component of the three-patch submission.

  • Daniel Gustafssonsaw the final versiontrailerTested the series, reported all tests passing, and supported replacing the Perl generator with the template in #3.
Add sort_template.h for making sort functions.
3 Mar 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

This lands the first component of #1, adding sort_template.h with formatting cleanup, documentation for ST_CHECK_FOR_INTERRUPTS, and two entries in src/tools/pgindent/typedefs.list. The other two components landed separately.

  • Daniel Gustafssonsaw the final versiontrailerBuilt and benchmarked a template-generated string sort, verified the tests and documentation, and identified the indentation issue corrected before landing in #3.

Credits across 9 commits

Author
Thomas MunroLLM7
David Rowley1
Reviewer
Daniel Gustafsson3
John Naylorcommitter3
Andres Freund2
Committer
Thomas Munro5
John Naylor3
David Rowley1

N LLM means N of the credits come from LLM analysis, not from commit trailers.