Outdated description for effective_io_concurrency
Started by Thomas Munroalmost 5 years ago2 messages
Hello,
Andrew Gierth pointed out that I left behind some outdated advice
about RAID spindles in the GUC's extra description field, in commit
b09ff536. Let's just drop that description. Patch attached.
Attachments:
0001-Remove-outdated-reference-to-RAID-spindles.patchtext/x-patch; charset=US-ASCII; name=0001-Remove-outdated-reference-to-RAID-spindles.patchDownload
From bb2fad4c540b18ad1683f7d69783f9b2634b1da2 Mon Sep 17 00:00:00 2001
From: Thomas Munro <thomas.munro@gmail.com>
Date: Sat, 20 Feb 2021 21:11:37 +1300
Subject: [PATCH] Remove outdated reference to RAID spindles.
Commit b09ff536 left behind some outdated advice in the "extra_desc"
field of the GUC "effective_io_concurrency". Remove it.
Back-patch to 13.
Reported-by: Andrew Gierth <andrew@tao11.riddles.org.uk>
---
src/backend/utils/misc/guc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 00018abb7d..260ec7b97e 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2951,7 +2951,7 @@ static struct config_int ConfigureNamesInt[] =
PGC_USERSET,
RESOURCES_ASYNCHRONOUS,
gettext_noop("Number of simultaneous requests that can be handled efficiently by the disk subsystem."),
- gettext_noop("For RAID arrays, this should be approximately the number of drive spindles in the array."),
+ NULL,
GUC_EXPLAIN
},
&effective_io_concurrency,
--
2.30.0
Re: Outdated description for effective_io_concurrency
On Sat, Feb 20, 2021 at 09:28:39PM +1300, Thomas Munro wrote:
Hello,
Andrew Gierth pointed out that I left behind some outdated advice
about RAID spindles in the GUC's extra description field, in commit
b09ff536. Let's just drop that description. Patch attached.
+1.