Mar 2021

3 commits
Use lfirst_int in cmp_list_len_contents_asc
19 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

The trailer-linked follow-up replaces two intVal(ListCell) calls with lfirst_int() in src/backend/parser/parse_agg.c; every attached version, including #9, contains the faulty calls. The commit describes a Valgrind finding, but the supplied messages contain no matching fix patch b822ae13ea.

Fix misuse of foreach_delete_current().
18 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Following the compiler-warning report #14, Tom Lane diagnosed and committed the fix without an attached patch #20. It assigns foreach_delete_current() back to result and replaces list_nth_node(..., 0) with linitial_node() in src/backend/parser/parse_agg.c 1d581ce712.

Implement GROUP BY DISTINCT
18 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #91 of 3 reviewers saw the final version

The complete 18-file diff matches #9 after excluding base hashes and hunk positions, including the GroupClause/SetQuantifier grammar changes and ruleutils.c deparsing. Tomas Vondra confirmed the push in #11, and the commit credits patch sender Vik Fearing as author be45be9c33.

  • Erik Rijkerssaw an earlier versiontrailerErik identified the missing sql_features.txt field in #2 and privately reported the documentation typo fixed in #5, before the later grammar restructuring and deparser addition.
  • Georgios Kokolatossaw an earlier versiontrailerGeorgios reported passing tests and reviewed documentation and comparator placement in #4, then reaffirmed his review for #5 in #6, before the grammar and deparser changes.
  • Tomas Vondrasaw the final versiontrailerTomas requested grammar cleanup and documentation indexing in #7, reviewed the resulting final version in #10, and committed it as confirmed in #11.

Credits across 3 commits

Author
Tom LaneLLM1
Tomas VondraLLM1
Vik Fearing1
Reviewer
Erik Rijkers1
Georgios Kokolatos1
Tomas Vondra1
Committer
Tomas Vondra2
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.