[PATCH] pgbench: Remove ecnt, a member variable of CState

Started by miyake_koutaabout 5 years ago5 messageshackers
Jump to latest
#1miyake_kouta
miyake_kouta@oss.nttdata.com

Hi.

I created a patch to remove ecnt which is a member variable of CState.
This variable is incremented in some places, but it's not used for any
purpose.
Also, the current pgbench's client abandons processing after hitting
error, so this variable is no need, I think.

Regards
--
Kota Miyake

Attachments:

remove_ecnt.patchtext/x-diff; name=remove_ecnt.patchDownload+0-4
#2Michael Paquier
michael@paquier.xyz
In reply to: miyake_kouta (#1)
Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

On Fri, Feb 26, 2021 at 05:39:31PM +0900, miyake_kouta wrote:

Also, the current pgbench's client abandons processing after hitting error,
so this variable is no need, I think.

Agreed. Its last use was in 12788ae, as far as I can see. So let's
just cleanup that.
--
Michael

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Michael Paquier (#2)
Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

On 2021-Feb-26, Michael Paquier wrote:

On Fri, Feb 26, 2021 at 05:39:31PM +0900, miyake_kouta wrote:

Also, the current pgbench's client abandons processing after hitting error,
so this variable is no need, I think.

Agreed. Its last use was in 12788ae, as far as I can see. So let's
just cleanup that.

+1

--
�lvaro Herrera Valdivia, Chile

#4Michael Paquier
michael@paquier.xyz
In reply to: Alvaro Herrera (#3)
Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

On Fri, Feb 26, 2021 at 04:36:41PM -0300, Alvaro Herrera wrote:

+1

Thanks, done.
--
Michael

#5miyake_kouta
miyake_kouta@oss.nttdata.com
In reply to: Michael Paquier (#4)
Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

2021-02-28 08:06, Michael Paquier wrote:

On Fri, Feb 26, 2021 at 04:36:41PM -0300, Alvaro Herrera wrote:

+1

Thanks, done.
--
Michael

Thanks for reviewing and committing this patch!

Regards
--
Kota Miyake