GiST comment improvement

Started by Bruce Momjianabout 5 years ago4 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

In talking to Teodor this week, I have written the attached C comment
patch which improves our description of GiST's NSN and GistBuildLSN
values.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Attachments:

gist.difftext/x-diff; charset=us-asciiDownload+12-5
#2Andrey Borodin
amborodin@acm.org
In reply to: Bruce Momjian (#1)
Re: GiST comment improvement

2 марта 2021 г., в 21:40, Bruce Momjian <bruce@momjian.us> написал(а):

In talking to Teodor this week, I have written the attached C comment
patch which improves our description of GiST's NSN and GistBuildLSN
values.

I'd suggest also add NSN acronym description to Concurrency section of src/backend/access/gist/README. And maybe even to doc/src/sgml/acronyms.sgml. Just for connectivity.

Thanks!

Best regards, Andrey Borodin.

#3Bruce Momjian
bruce@momjian.us
In reply to: Andrey Borodin (#2)
Re: GiST comment improvement

On Tue, Mar 2, 2021 at 10:25:23PM +0500, Andrey Borodin wrote:

2 марта 2021 г., в 21:40, Bruce Momjian <bruce@momjian.us> написал(а):

In talking to Teodor this week, I have written the attached C comment
patch which improves our description of GiST's NSN and GistBuildLSN
values.

I'd suggest also add NSN acronym description to Concurrency section of src/backend/access/gist/README. And maybe even to doc/src/sgml/acronyms.sgml. Just for connectivity.

Uh, NSN is only something that exists in the source code. Do we document
those cases?

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

#4Bruce Momjian
bruce@momjian.us
In reply to: Bruce Momjian (#1)
Re: GiST comment improvement

On Tue, Mar 2, 2021 at 11:40:21AM -0500, Bruce Momjian wrote:

In talking to Teodor this week, I have written the attached C comment
patch which improves our description of GiST's NSN and GistBuildLSN
values.

Patch applied.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee