Mar 2021

1 commit
Fix timeline assignment in checkpoints with 2PC transactions
21 Mar 2021Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.3+3 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #181 of 4 reviewers saw the final version

The commit preserves the executable twophase.c changes from #18, edits comments, renumbers the TAP test to 023_pitr_prepared_xact.pl, and replaces WAL-file comparison with a checkpoint and crash-restart check, as explained in #19. Although Michael Paquier submitted the final patch, the commit credits Soumyadeep Chakraborty, Jimmy Yih and Kevin Yeap as authors, consistent with #1.

  • Heikki Linnakangassaw an earlier versionLLM analysis, 99% sureIn #3, identified that #2 restored the timeline too late to protect LogStandbySnapshot() and proposed fixing it inside XlogReadTwoPhaseData(), before subsequent implementation changes.
  • Fujii Masaosaw an earlier versionLLM analysis, 90% sureIn #4, proposed moving the fix into the shared reader, prompting #5, and in #8 challenged the compatibility rationale behind #6, before later redesigns.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 94% sureIn #6 and #15, examined the proposed reader changes and argued that callers could depend on ThisTimeLineID updates, a concern addressed by the later rework in #18.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Jimmy Yih1
Kevin Yeap1
Soumyadeep Chakraborty1
Reviewer
Michael Paquiercommitter1
Committer
Michael Paquier1