make coverage-html would fail within build directory separate from source tree

Started by walkeralmost 5 years ago10 messages

failaway@qq.com

almost 5 years ago

Hi, hackers

During installation from source code, I created a build directory separate from the source tree, and execute the following command in the build directory:
/home/postgres/postgresql-13.2/configure -- enable-coverage
make
make check
make coverage-html

However, while executing make coverage-html, it failed with the following error messages:
/bin/lcov --gcov-tool /bin/gcov -q --no-external -c -i -d . -d /home/postgres/postgresql-13.2/ -o lcve_base.info
...
geninfo: ERROR: no .gcno files found in /home/postgres/postgresql-13.2/!
make: *** [lcov_base.info] Error 255
make: *** Deleting file 'lcov_base.info'

if I repeat the above steps within the source tree directory, make coverage-html works fine. From the official documentation, I didn't find any limitations for "make coverage-html", not sure if I miss something.

thanks
walker
 

Alvaro Herrera

alvherre@alvh.no-ip.org

almost 5 years ago

In reply to: walker (#1)

Re: make coverage-html would fail within build directory separate from source tree

On 2021-Mar-04, walker wrote:

Hi, hackers

During installation from source code, I created a build directory separate from the source tree, and execute the following command in the build directory:
/home/postgres/postgresql-13.2/configure -- enable-coverage
make
make check
make coverage-html

However, while executing make coverage-html, it failed with the following error messages:
/bin/lcov --gcov-tool /bin/gcov -q --no-external -c -i -d . -d /home/postgres/postgresql-13.2/ -o lcve_base.info
...
geninfo: ERROR: no .gcno files found in /home/postgres/postgresql-13.2/!
make: *** [lcov_base.info] Error 255
make: *** Deleting file 'lcov_base.info'

Hmm, it works fine for me. config.log says I do this (in
/pgsql/build/master-coverage):

$ /pgsql/source/REL_13_STABLE/configure --enable-debug --enable-depend --enable-cassert --enable-coverage --cache-file=/home/alvherre/run/pgconfig.master-coverage.cache --enable-thread-safety --enable-tap-tests --with-python --with-perl --with-tcl --with-openssl --with-libxml --with-tclconfig=/usr/lib/tcl8.6 PYTHON=/usr/bin/python3 --prefix=/pgsql/install/master-coverage --with-pgport=55451

I do run "make install" too, though (and "make -C contrib install").
Not sure if that makes a difference.
But for sure there are no .gcno files in the source dir -- they're all
in the build dir.

--
ï¿½lvaro Herrera Valdivia, Chile
"La persona que no querï¿½a pecar / estaba obligada a sentarse
en duras y empinadas sillas / desprovistas, por cierto
de blandos atenuantes" (Patricio Vogel)

Alvaro Herrera

alvherre@alvh.no-ip.org

almost 5 years ago

In reply to: Alvaro Herrera (#2)

Re: make coverage-html would fail within build directory separate from source tree

On 2021-Mar-04, Alvaro Herrera wrote:

On 2021-Mar-04, walker wrote:

Hi, hackers

During installation from source code, I created a build directory separate from the source tree, and execute the following command in the build directory:
/home/postgres/postgresql-13.2/configure -- enable-coverage
make
make check
make coverage-html

However, while executing make coverage-html, it failed with the following error messages:
/bin/lcov --gcov-tool /bin/gcov -q --no-external -c -i -d . -d /home/postgres/postgresql-13.2/ -o lcve_base.info
...
geninfo: ERROR: no .gcno files found in /home/postgres/postgresql-13.2/!

"make coverage-html" outputs this: note that I get a WARNING about the
source directory rather than an ERROR:

/usr/bin/lcov --gcov-tool /usr/bin/gcov -q --no-external -c -i -d . -d /pgsql/source/REL_13_STABLE/ -o lcov_base.info
geninfo: WARNING: no .gcno files found in /pgsql/source/REL_13_STABLE/ - skipping!
/usr/bin/lcov --gcov-tool /usr/bin/gcov -q --no-external -c -d . -d /pgsql/source/REL_13_STABLE/ -o lcov_test.info
geninfo: WARNING: no .gcda files found in /pgsql/source/REL_13_STABLE/ - skipping!
rm -rf coverage
/usr/bin/genhtml -q --legend -o coverage --title='PostgreSQL 13.2' --num-spaces=4 lcov_base.info lcov_test.info
touch coverage-html-stamp

(In my system, /pgsql is a symlink to /home/alvhere/Code/pgsql/)

$ geninfo --version
geninfo: LCOV version 1.13

--
ï¿½lvaro Herrera Valdivia, Chile

walker

failaway@qq.com

almost 5 years ago

In reply to: Alvaro Herrera (#2)

Re: make coverage-html would fail within build directory separate from source tree

thanks for your reply. it indeed that there are no .gcon files in source tree directory, they're in build tree directory, which results in failures.

That's a bit wired.

Add more detailed testing steps:
mkdir build_dir
cd build_dir
/home/postgres/postgresql-13.2/configure -- enable-coverage
make
make check
make coverage-html

thanks
walker

------------------ Original ------------------
From: "Alvaro Herrera" <alvherre@alvh.no-ip.org>;
Date: Thu, Mar 4, 2021 09:31 PM
To: "walker"<failaway@qq.com>;
Cc: "pgsql-hackers"<pgsql-hackers@lists.postgresql.org>;
Subject: Re: make coverage-html would fail within build directory separate from source tree

On 2021-Mar-04, walker wrote:

> Hi, hackers
>
> During installation from source code, I created a build directory separate from the source tree, and execute the following command in the build directory:
> /home/postgres/postgresql-13.2/configure -- enable-coverage
> make
> make check
> make coverage-html
>
>
> However, while executing make coverage-html, it failed with the following error messages:
> /bin/lcov --gcov-tool /bin/gcov -q --no-external -c -i -d . -d /home/postgres/postgresql-13.2/ -o lcve_base.info
> ...
> geninfo: ERROR: no .gcno files found in /home/postgres/postgresql-13.2/!
> make: *** [lcov_base.info] Error 255
> make: *** Deleting file 'lcov_base.info'

Hmm, it works fine for me.  config.log says I do this (in
/pgsql/build/master-coverage):

I do run "make install" too, though (and "make -C contrib install").
Not sure if that makes a difference. 
But for sure there are no .gcno files in the source dir -- they're all
in the build dir.

--
Álvaro Herrera       Valdivia, Chile
"La persona que no quería pecar / estaba obligada a sentarse
 en duras y empinadas sillas    / desprovistas, por cierto
 de blandos atenuantes"                          (Patricio Vogel)

Alvaro Herrera

alvherre@alvh.no-ip.org

almost 5 years ago

In reply to: walker (#4)

Re: make coverage-html would fail within build directory separate from source tree

On 2021-Mar-04, walker wrote:

thanks for your reply. it indeed that there are no .gcon files in source tree directory, they're in build tree directory, which results in failures.

That's a bit wired.

Add more detailed testing steps:
mkdir build_dir
cd build_dir
/home/postgres/postgresql-13.2/configure -- enable-coverage
make
make check
make coverage-html

Hmm, my build dir is not inside the source dir -- is yours? Maybe that
makes a difference? Also, what version of lcov do you have?

--
ï¿½lvaro Herrera 39ï¿½49'30"S 73ï¿½17'W
"Someone said that it is at least an order of magnitude more work to do
production software than a prototype. I think he is wrong by at least
an order of magnitude." (Brian Kernighan)

walker

failaway@qq.com

almost 5 years ago

In reply to: Alvaro Herrera (#5)

Re: make coverage-html would fail within build directory separate from source tree

The same, the build directory is outside the source tree.

the version of lcov is 1.10

thanks
walker

------------------ Original ------------------
From: "Alvaro Herrera" <alvherre@alvh.no-ip.org>;
Date: Thu, Mar 4, 2021 10:05 PM
To: "walker"<failaway@qq.com>;
Cc: "pgsql-hackers"<pgsql-hackers@lists.postgresql.org>;
Subject: Re: make coverage-html would fail within build directory separate from source tree

On 2021-Mar-04, walker wrote:

> thanks for your reply. it indeed that there are no .gcon files in source tree directory, they're in build tree directory, which results in failures.
>
>
> That's a bit wired.
>
>
> Add more detailed testing steps:
> mkdir build_dir
> cd build_dir
> /home/postgres/postgresql-13.2/configure -- enable-coverage
> make
> make check
> make coverage-html

Hmm, my build dir is not inside the source dir -- is yours?  Maybe that
makes a difference?  Also, what version of lcov do you have?

--
Álvaro Herrera                            39°49'30"S 73°17'W
"Someone said that it is at least an order of magnitude more work to do
production software than a prototype. I think he is wrong by at least
an order of magnitude."                              (Brian Kernighan)

Alvaro Herrera

alvherre@alvh.no-ip.org

almost 5 years ago

In reply to: walker (#6)

Re: make coverage-html would fail within build directory separate from source tree

On 2021-Mar-04, walker wrote:

The same, the build directory is outside the source tree.

the version of lcov is 1.10

That seems *really* ancient. Please try with a fresher version.

--
ï¿½lvaro Herrera 39ï¿½49'30"S 73ï¿½17'W
"How amazing is that? I call it a night and come back to find that a bug has
been identified and patched while I sleep." (Robert Davidson)
http://archives.postgresql.org/pgsql-sql/2006-03/msg00378.php

walker

failaway@qq.com

almost 5 years ago

In reply to: Alvaro Herrera (#7)

Re: make coverage-html would fail within build directory separate from source tree

install a newer version of lcov 1.13, it works fine with WARNING just same as yours.

much appreciated

thanks
walker

------------------ Original ------------------
From: "Alvaro Herrera" <alvherre@alvh.no-ip.org>;
Date: Thu, Mar 4, 2021 10:20 PM
To: "walker"<failaway@qq.com>;
Cc: "pgsql-hackers"<pgsql-hackers@lists.postgresql.org>;
Subject: Re: make coverage-html would fail within build directory separate from source tree

On 2021-Mar-04, walker wrote:

> The same, the build directory is outside the source tree.
>
>
> the version of lcov is 1.10

That seems *really* ancient.  Please try with a fresher version.

--
Álvaro Herrera                            39°49'30"S 73°17'W
"How amazing is that? I call it a night and come back to find that a bug has
been identified and patched while I sleep."                (Robert Davidson)
               http://archives.postgresql.org/pgsql-sql/2006-03/msg00378.php

Import Notes

Resolved by subject fallback

Tom Lane

tgl@sss.pgh.pa.us

almost 5 years ago

In reply to: Alvaro Herrera (#5)

Re: make coverage-html would fail within build directory separate from source tree

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

Hmm, my build dir is not inside the source dir -- is yours?

I recall that the gcc build instructions strongly warn against that
sort of setup. Maybe we should too?

Actually, our build instructions already say this specifically:

You can also run configure in a directory outside the source tree, and
then build there, if you want to keep the build directory separate
from the original source files. This procedure is called a VPATH
build ...

Maybe "outside the source tree" needs to be emphasized a bit more.

regards, tom lane

#10

walker

failaway@qq.com

almost 5 years ago

In reply to: Tom Lane (#9)

Re: make coverage-html would fail within build directory separate from source tree

Thanks for your reminder, Tom.

Before I understand VPATH well, I always thought "outside the source tree" means the build tree is not under source tree.

Here because of VPATH build, which means build tree should be a subdirectory of source tree. according to this rule, I retry this scenario with old version of lcov(1.10).
tar -zxf source_dir.tar.gz
cd source_dir
mkdir build_dir && cd build_dir
../configure --enable-coverage
make
make check
make coverage-html

And "make coverage-html" works fine, no any error, or warning, output is like this:
/bin/lcov --gcov-tool /bin/gcov -q --no-external -c -i -d . -d source_dir/build_dir/../ -o lcov_base.info
/bin/lcov --gcov-tool /bin/gcov -q --no-external -c -d . -d source_dir/build_dir/../ -o lcov_test.info
rm -rf coverage
/bin/genhtml -q --legend -o coverage --title='PostgreSQL 13.2' --num-spaces=4 lcov_base.info lcov_test.info
touch coverage-html-stamp

thanks
walker

------------------ Original ------------------
From: "Tom Lane" <tgl@sss.pgh.pa.us>;
Date: Thu, Mar 4, 2021 11:21 PM
To: "Alvaro Herrera"<alvherre@alvh.no-ip.org>;
Cc: "walker"<failaway@qq.com>;"pgsql-hackers"<pgsql-hackers@lists.postgresql.org>;
Subject: Re: make coverage-html would fail within build directory separate from source tree

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Hmm, my build dir is not inside the source dir -- is yours?

I recall that the gcc build instructions strongly warn against that
sort of setup.  Maybe we should too?

Actually, our build instructions already say this specifically:

    You can also run configure in a directory outside the source tree, and
    then build there, if you want to keep the build directory separate
    from the original source files. This procedure is called a VPATH
    build ...

Maybe "outside the source tree" needs to be emphasized a bit more.

regards, tom lane