pg_subscription - substream column?
I noticed that the PG docs [1]https://www.postgresql.org/docs/devel/catalog-pg-subscription.html for the catalog pg_subscription doesn't
have any mention of the substream column.
Accidental omission by commit 4648243 [2]https://github.com/postgres/postgres/commit/464824323e57dc4b397e8b05854d779908b55304 from last year?
----
[1]: https://www.postgresql.org/docs/devel/catalog-pg-subscription.html
[2]: https://github.com/postgres/postgres/commit/464824323e57dc4b397e8b05854d779908b55304
Kind Regards,
Peter Smith.
Fujitsu Australia
On Tue, Mar 16, 2021 at 3:35 AM Peter Smith <smithpb2250@gmail.com> wrote:
I noticed that the PG docs [1] for the catalog pg_subscription doesn't
have any mention of the substream column.Accidental omission by commit 4648243 [2] from last year?
Right. I'll fix this unless you or someone else is interested in
providing a patch for this.
--
With Regards,
Amit Kapila.
On Tue, Mar 16, 2021 at 7:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Tue, Mar 16, 2021 at 3:35 AM Peter Smith <smithpb2250@gmail.com> wrote:
I noticed that the PG docs [1] for the catalog pg_subscription doesn't
have any mention of the substream column.Accidental omission by commit 4648243 [2] from last year?
Right. I'll fix this unless you or someone else is interested in
providing a patch for this.
Sure, I will send a patch for it tomorrow.
----
Kind Regards,
Peter Smith.
Fujitsu Australia.
On Tue, Mar 16, 2021 at 5:27 PM Peter Smith <smithpb2250@gmail.com> wrote:
On Tue, Mar 16, 2021 at 7:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Tue, Mar 16, 2021 at 3:35 AM Peter Smith <smithpb2250@gmail.com> wrote:
I noticed that the PG docs [1] for the catalog pg_subscription doesn't
have any mention of the substream column.Accidental omission by commit 4648243 [2] from last year?
Right. I'll fix this unless you or someone else is interested in
providing a patch for this.Sure, I will send a patch for it tomorrow.
Attached, please find the patch to update the description of substream
in pg_subscription.
--
With Regards,
Amit Kapila.
Attachments:
v1-0001-Doc-Add-a-description-of-substream-in-pg_subscrip.patchapplication/octet-stream; name=v1-0001-Doc-Add-a-description-of-substream-in-pg_subscrip.patchDownload
From 3728ed1958786d8d8ed678bbf19a5d134d6c6a00 Mon Sep 17 00:00:00 2001
From: Amit Kapila <akapila@postgresql.org>
Date: Tue, 16 Mar 2021 19:11:46 +0530
Subject: [PATCH v1] Doc: Add a description of substream in pg_subscription.
Commit 464824323e added a new column substream in pg_subscription but
forgot to update the docs.
Reported-by: Peter Smith
Author: Amit Kapila
Discussion: https://postgr.es/m/CAHut+PuPGGASnh2Dy37VYODKULVQo-5oE=Shc6gwtRizDt==cA@mail.gmail.com
---
doc/src/sgml/catalogs.sgml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index b1de6d0..5c9f4af 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -7567,6 +7567,16 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l
<row>
<entry role="catalog_table_entry"><para role="column_definition">
+ <structfield>substream</structfield> <type>bool</type>
+ </para>
+ <para>
+ If true, the subscription will allow streaming of in-progress
+ transactions
+ </para></entry>
+ </row>
+
+ <row>
+ <entry role="catalog_table_entry"><para role="column_definition">
<structfield>subconninfo</structfield> <type>text</type>
</para>
<para>
--
1.8.3.1
On Wed, Mar 17, 2021 at 12:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
Attached, please find the patch to update the description of substream
in pg_subscription.
I applied your patch and regenerated the PG docs to check the result.
LGTM.
----
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Mar 17, 2021 at 4:56 AM Peter Smith <smithpb2250@gmail.com> wrote:
On Wed, Mar 17, 2021 at 12:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
Attached, please find the patch to update the description of substream
in pg_subscription.I applied your patch and regenerated the PG docs to check the result.
LGTM.
Pushed!
--
With Regards,
Amit Kapila.