comment fix in postmaster.c
While I worked on a patch, I noticed a comment that is inconsistent
with the fact.
* SIGQUIT is the special signal that says exit without proc_exit
* and let the user know what's going on. But if SendStop is set
* (-s on command line), then we send SIGSTOP instead, so that we
* can get core dumps from all backends by hand.
SendStop is set by "-T" option. It was changed by 86c23a6eb2 from "-s"
in 2006.
The attaches fixes the comment for the master branch.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
postmaster_comment_fix.patchtext/x-patch; charset=us-asciiDownload
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
index e8af05c04e..9bef3a9adb 100644
--- a/src/backend/postmaster/postmaster.c
+++ b/src/backend/postmaster/postmaster.c
@@ -3471,7 +3471,7 @@ HandleChildCrash(int pid, int exitstatus, const char *procname)
*
* SIGQUIT is the special signal that says exit without proc_exit
* and let the user know what's going on. But if SendStop is set
- * (-s on command line), then we send SIGSTOP instead, so that we
+ * (-T on command line), then we send SIGSTOP instead, so that we
* can get core dumps from all backends by hand.
*/
if (take_action)
@@ -3514,7 +3514,7 @@ HandleChildCrash(int pid, int exitstatus, const char *procname)
*
* SIGQUIT is the special signal that says exit without proc_exit
* and let the user know what's going on. But if SendStop is set
- * (-s on command line), then we send SIGSTOP instead, so that we
+ * (-T on command line), then we send SIGSTOP instead, so that we
* can get core dumps from all backends by hand.
*
* We could exclude dead_end children here, but at least in the
On 2021/03/16 16:51, Kyotaro Horiguchi wrote:
While I worked on a patch, I noticed a comment that is inconsistent
with the fact.* SIGQUIT is the special signal that says exit without proc_exit
* and let the user know what's going on. But if SendStop is set
* (-s on command line), then we send SIGSTOP instead, so that we
* can get core dumps from all backends by hand.SendStop is set by "-T" option. It was changed by 86c23a6eb2 from "-s"
in 2006.The attaches fixes the comment for the master branch.
Thanks for the path! LGTM. Barring any objection, I will push the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION