Code comment fix

Started by Vik Fearingalmost 5 years ago3 messages

vik@postgresfriends.org

almost 5 years ago

1 attachment(s)

When table oids were removed by commit 578b229718e, the function
CatalogTupleInsert() was modified to return void but its comment was
left intact. Here is a trivial patch to fix that.
--
Vik Fearing

Attachments:

CatalogTupleInsert_comment.difftext/x-patch; charset=UTF-8; name=CatalogTupleInsert_comment.diffDownload

diff --git a/src/backend/catalog/indexing.c b/src/backend/catalog/indexing.c
index 284ceaa6b9..4d1440cd3a 100644
--- a/src/backend/catalog/indexing.c
+++ b/src/backend/catalog/indexing.c
@@ -210,7 +210,6 @@ CatalogTupleCheckConstraints(Relation heapRel, HeapTuple tup)
  * CatalogTupleInsert - do heap and indexing work for a new catalog tuple
  *
  * Insert the tuple data in "tup" into the specified catalog relation.
- * The Oid of the inserted tuple is returned.
  *
  * This is a convenience routine for the common case of inserting a single
  * tuple in a system catalog; it inserts a new heap tuple, keeping indexes

Michael Paquier

michael@paquier.xyz

almost 5 years ago

In reply to: Vik Fearing (#1)

Re: Code comment fix

On Wed, Mar 17, 2021 at 08:31:16AM +0100, Vik Fearing wrote:

When table oids were removed by commit 578b229718e, the function
CatalogTupleInsert() was modified to return void but its comment was
left intact. Here is a trivial patch to fix that.

Thanks, Vik. Good catch. I'll fix that in a bit.
--
Michael

Vik Fearing

vik@postgresfriends.org

almost 5 years ago

In reply to: Michael Paquier (#2)

Re: Code comment fix

On 3/17/21 9:11 AM, Michael Paquier wrote:

On Wed, Mar 17, 2021 at 08:31:16AM +0100, Vik Fearing wrote:

When table oids were removed by commit 578b229718e, the function
CatalogTupleInsert() was modified to return void but its comment was
left intact. Here is a trivial patch to fix that.

Thanks, Vik. Good catch. I'll fix that in a bit.

Cheers.
--
Vik Fearing