hint Consider using pg_file_read()

Started by Sergei Kornilovalmost 5 years ago3 messages

Hello
In src/backend/utils/adt/genfile.c in pg_read_file we have errhint

errhint("Consider using %s, which is part of core, instead.",
"pg_file_read()")

Shouldn't pg_read_file() be written here?

regards, Sergei

#2Magnus Hagander
magnus@hagander.net
In reply to: Sergei Kornilov (#1)
Re: hint Consider using pg_file_read()

On Thu, Mar 18, 2021 at 10:58 AM Sergei Kornilov <sk@zsrv.org> wrote:

Hello
In src/backend/utils/adt/genfile.c in pg_read_file we have errhint

errhint("Consider using %s, which is part of core, instead.",
"pg_file_read()")

Shouldn't pg_read_file() be written here?

Yup, it certainly looks that way. There's a really funky combination
of names between SQL and backend there that I guess threw the original
author off.

Will fix.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In reply to: Magnus Hagander (#2)
Re: hint Consider using pg_file_read()

I noticed that the fix has been committed, thank you!

regards, Sergei