Apr - May 2021

9 commits
Doc: Update logical decoding stats information.
25 May 2021Amit Kapilamaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 100% surelanded as postedfrom patchset #2001 of 1 reviewer saw the final version

The logicaldecoding.sgml addition matches #200, with only whitespace and SGML line wrapping changed; #201 confirms it was pushed.

  • Amit Kapilasaw the final versiontrailerAmit requested the documentation addition in #199 and committed it as confirmed in #201.
Fix tests for replication slots stats.
13 May 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1921 of 1 reviewer saw the final version

The SQL and expected-output changes exactly match #192, combining Sawada's counter-check correction from #189 with removal of racy reset tests; the commit credits both authors.

  • Amit Kapilasaw the final versiontrailerAmit identified the additional reset race in #191, requested test removal, and confirmed committing the combined fix in #197.
Update replication statistics after every stream/spill.
6 May 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1761 of 1 reviewer saw the final version

The diff exactly matches Amit's combined submission #176, containing Vignesh's reporting implementation from #142 and Masahiko Sawada's documentation changes from #175.

  • Amit Kapilasaw the final versiontrailerAmit simplified the context API in #141, assembled the final implementation and documentation in #176, and committed it.
Fix the computation of slot stats for 'total_bytes'.
3 May 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1662 of 2 reviewers saw the final version

The reorderbuffer.c changes match #166 exactly; Amit forwarded Sawada's implementation from #163 with explanatory comment edits.

  • Vignesh Csaw the final versiontrailerVignesh exposed a remaining accounting error through testing in #162 and reviewed the corrected version in #165, after which only comments changed.
  • Amit Kapilasaw the final versiontrailerAmit identified missing subtransaction accounting in #147, reproduced spill discrepancies in #161, and prepared the committed version in #166.
Another try to fix the test case added by commit f5fc2f5b23.
30 Apr 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #1582 of 2 reviewers saw the final version

The SQL and expected-output changes exactly match #158, including the distinct regression slot name and explicit logical_decoding_work_mem setting.

  • Amit Kapilasaw the final versiontrailerAmit analyzed the stale-slot race in #153, reviewed the resulting patch in #159, and confirmed its commit in #164.
  • Vignesh Csaw the final versiontrailerVignesh reviewed the distinct-slot-name solution in #160, and the patch subsequently landed unchanged.
Use HTAB for replication slot statistics.
27 Apr 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1231 of 3 reviewers saw the final version

The HTAB implementation and TAP changes match #123; the only additional change is the catalog-version bump in src/include/catalog/catversion.h.

  • Amit Kapilasaw the final versiontrailerAmit reviewed cleanup and creation-message handling, corrected memory-context allocation in #120, and reviewed the final version in #124 before committing.
  • Vignesh Csaw an earlier versiontrailerVignesh reviewed code and typedef handling in #101 and tested catalog compatibility in #105, before subsequent hash-allocation and memory-context changes.
  • Dilip Kumarsaw an earlier versiontrailerDilip reviewed the relocation of slot-existence checks in #109, before the later hash-allocation and memory-context corrections.
Fix test case added by commit f5fc2f5b23.
19 Apr 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #921 of 1 reviewer saw the final version

Amit explicitly selected #92 in #94; the commit adjusts test predicates, incorporates Justin Pryzby's inline documentation edits from #78, and bumps PGSTAT_FILE_FORMAT_ID.

  • Amit Kapilasaw the final versiontrailerAmit compared both proposed test repairs and explained his selection and small committer edits in #94.
Add information of total data processed to replication slot stats.
16 Apr 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #762 of 2 reviewers saw the final version

The total-counter implementation and tests match Amit's consolidated submission #76, apart from a catalog-version bump; the patch and commit credit Vignesh and Amit as authors.

  • Sawada Masahikosaw the final versiontrailerSawada tested accounting in #62, corrected final documentation in #75, and reviewed the updated submission in #77.
  • Amit Kapilasaw the final versiontrailerAmit supplied accounting corrections in #46 and #70, consolidated the implementation in #72, and committed the final revision.
Use NameData datatype for slotname in stats.
14 Apr 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #652 of 2 reviewers saw the final version

The diff exactly matches the NameData and pgstat_report_replslot signature component of #65; its total-counter, HTAB, and test components were left for subsequent work.

  • Sawada Masahikosaw the final versiontrailerSawada reviewed the type and interface changes in #28 and explicitly retained the finalized NameData component unchanged when assembling #52.
  • Amit Kapilasaw the final versiontrailerAmit requested a separate NameData component in #43, caught misplaced fields in #49, and committed the resulting component.

Credits across 9 commits

Author
vignesh C6
Masahiko Sawada5
Amit Kapila1
Justin Pryzby1
test case by Vignesh C1
Reviewer
Amit Kapila9
vignesh C3
Masahiko Sawada2
Dilip Kumar1
Reported by
Andres Freund2
Tom Lane based on buildfarm reports2
Tom Lane as per buildfarm1
Committer
Amit Kapila9