Jul 2021

1 commit
Replace RelationOpenSmgr() with RelationGetSmgr().
12 Jul 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.7REL_13_STABLE13.10+2 moreAlso in: CREATE UNLOGGED TABLE seq faults when debug_discard_caches=1 (landed as posted)
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #321 of 5 reviewers saw the final version

The commit retains the 21-file accessor conversion from #32, but additionally replaces cached pointers in pg_visibility and RelationTruncate(), captures the RelationCopyStorage() error-path filename before ereport(), and expands lifetime warnings. Although #33 describes cosmetic adjustments, these local pointer-lifetime changes warrant moderate rather than light classification.

  • Michael Paquiersaw an earlier versionLLM analysis, 99% sureIn #17, he requested removal of the last heap.c caller and the obsolete RelationOpenSmgr() macro, which #18 implemented before subsequent pointer-lifetime revisions.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 100% sureHe reviewed the accessor notation in #19 and proposed temporary variables in #25, adopted in #26 but subsequently removed from many callers for safety.
  • Anastasia Lubennikovasaw an earlier versionLLM analysis, 100% sureIn #27, she reported passing installcheck-world and feature testing and said the patch looked good, before the pointer-caching changes were revised.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 98% sureIn #31, he requested the explanatory accessor comment added in #32, but moderate pointer-lifetime edits still followed at commit time.
  • Tom Lanesaw the final versioncommittercommitted the patch

Mar 2021

1 commit
Avoid possible crash while finishing up a heap rewrite.
23 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.3
LLM analysis, 100% suremodified before commitlight changesfrom patchset #22 of 2 reviewers saw the final version

The commit preserves the RelationOpenSmgr() fix from #2, adds an explanatory comment, and moves an existing open call beside its smgrextend() use in src/backend/access/heap/rewriteheap.c. Tom Lane also added empty-table clustering coverage in src/test/regress/sql/cluster.sql and its expected output.

  • Amit Langotesaw the final versionLLM analysis, 99% sureIn #3, he endorsed the diagnosis and fix in #2 and examined analogous storage-manager invalidation hazards; only light changes followed before commitment.
  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Amul SulLLM2
Tom LaneLLM1
Reviewer
Tom Lanecommitter2
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.