Nov 2023

2 commits
Add NOT NULL checking of pg_stat_statements_reset() in tests
27 Nov 2023Alexander Korotkovmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #893 of 11 reviewers saw the final version

The complete first patch in #89 matches the committed changes across all 16 SQL and expected-output files. The only substantive editorial difference is the commit-message typo correction requested in #91 and promised in #92.

  • Julien Rouhaudsaw the final versiontrailerReviewed the combined patch after timestamp-return test changes were introduced and explicitly endorsed the final two-patch series in #90.
  • Hayato Kurodano review foundtrailerHis reviews in #2 and #6 concern the original timestamp feature and precede the IS NOT NULL test conversion.
  • Yuki Seinono review foundtrailerThe review in #8 concerns extension versioning before the reset-return test changes existed.
  • Chengxi Sunno review foundtrailerThe successful testing reported in #15 covers the original timestamp patch, which did not contain this test conversion.
  • Anton Melnikovno review foundtrailerHis testing and design reviews through #26 predate the timestamp-return and IS NOT NULL changes.
  • Darren Rushno review foundtrailerThe commit credits Darren Rush, but the supplied thread contains no review activity by him.
  • Michael Paquiersaw the final versiontrailerExamined the IS NOT NULL conversion and proposed extracting it as a preparatory patch in #69, followed only by test adjustments and rebases.
  • Sergei Kornilovno review foundtrailerHis review in #72 addresses the feature patch's privileges and documentation, with no demonstrated review of the preparatory test patch.
  • Alena Rybakinano review foundtrailerHer review and acceptance in #82 and #86 concern reset implementation comments, not the preparatory SQL-test conversion.
  • Andrei Lepikhovno review foundtrailerHis discussion in #80 and #84 concerns timestamp and reset-interface design, without demonstrated review of this test-only change.
  • Alexander Korotkovsaw the final versioncommittercommitted the patch
Track statement entry timestamp in contrib/pg_stat_statements
27 Nov 2023Alexander Korotkovmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surelanded as postedfrom patchset #894 of 11 reviewers saw the final version

Matches the complete second patch in #89, including pg_stat_statements.c, the extension upgrade, documentation, and entry_timestamp tests; differences are indentation and comment wrapping. The attachment header and commit Author trailer credit Andrei Zubkov.

  • Julien Rouhaudsaw the final versiontrailerGuided the counter/reset design and implementation through several reviews, then explicitly said the final series looked good in #90.
  • Hayato Kurodasaw an earlier versiontrailerDiscussed timestamp overhead, preferred timestamps over deallocation numbers, and requested brace cleanup in #2 and #6, before the min/max redesign.
  • Yuki Seinosaw an earlier versiontrailerSupported the original timestamp patch and requested an extension-version bump in #8, before substantial feature expansion.
  • Chengxi Sunsaw an earlier versiontrailerReported successful installcheck-world and feature tests in #15, before independently resettable min/max statistics were introduced.
  • Anton Melnikovsaw an earlier versiontrailerTested these versions and reviewed auxiliary-counter naming, initialization, and reset behavior in #20, #23, and #26, before that design was replaced.
  • Darren Rushno review foundtrailerThe commit credits Darren Rush, but no message or review activity by him appears in the supplied thread.
  • Michael Paquiersaw an earlier versiontrailerRequested removal of redundant upgrade commands and separation of test changes in #69, before the later reset-function permission correction.
  • Sergei Kornilovsaw an earlier versiontrailerFound the missing reset-function privilege restriction and requested explicit min/max documentation in #72, with the access-control correction subsequently implemented in #73.
  • Alena Rybakinasaw the final versiontrailerReviewed reset lookup semantics and comments in #82 and accepted the clarified version in #86, after which only light changes and rebases followed.
  • Andrei Lepikhovsaw the final versiontrailerQuestioned the need for the second timestamp and reset interface in #80 and #84, reviewing the design that ultimately landed.
  • Alexander Korotkovsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Andrei Zubkov2
Reviewer
Alena Rybakina2
Alexander Korotkovcommitter2
Andrei Lepikhov2
Anton Melnikov2
Chengxi Sun2
Darren Rush2
Hayato Kuroda (Fujitsu)2
Julien Rouhaud2
Michael Paquier2
Seino Yuki2
Sergei Kornilov2
Committer
Alexander Korotkov2