May 2021

2 commits
Fix issues in pg_stat_wal.
19 May 2021Fujii Masaomaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 100% suremodified before commitlight changesfrom patchset #372 of 4 reviewers saw the final version

The executable changes match #37; differences are comment wrapping and rewritten BufferUsage/WalUsage documentation in src/include/executor/instrument.h. Fujii Masao confirms that he adjusted comments before pushing in #38.

  • Kyotaro Horiguchisaw an earlier versiontrailerIn #14, he reviewed #13, requested restoring the outer WAL check and consolidating reporting functions, before the later switch from resetting to cumulative counters.
  • Atsushi Torikoshisaw the final versiontrailerPosting as torikoshia, he corrected stale return-value documentation in #18 and reviewed spelling and capitalization in #34, after which only comment changes followed.
  • Andres Freundsaw an earlier versiontrailerHe reviewed the existing reporting code and its fast-return logic in #1 and #3 and argued for a pending flag in #10, but no attached version is explicitly identified as reviewed before the subsequent accounting rework.
  • Fujii Masaosaw the final versiontrailerHis reviews in #16, #23, #27, #32, and #36 shaped accounting, checks, and comments, and he reviewed and committed the final version as confirmed in #38.
Change data type of counters in BufferUsage and WalUsage from long to int64.
12 May 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: Add statistics to pg_stat_wal view for wal related parameter tuning (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #261 of 1 reviewer saw the final version

The commit takes only the second patch of #26, with identical added and removed lines in instrument.h, explain.c, and vacuumlazy.c; the WAL-reporting patch remains separate. This matching April submission is newer than every supplied patchset in thread #43114, whose latest submission was in January.

  • Fujii Masaosaw the final versiontrailerHe identified missing counter-consumer changes in #23, requested a separate int64 patch in #25, approved the resulting second patch in #30, and committed it.

Credits across 2 commits

Author
Masahiro Ikeda2
Reviewer
Fujii Masao2
Andres Freund1
Kyotaro Horiguchi1
torikoshia1
Reported by
Andres Freund1
Committer
Fujii Masao2