extra semicolon in postgres_fdw test cases
Hi,
Noticed that an extra semicolon in a couple of test cases related to
postgres_fdw. Removed that in the attached patch. It can be backported till
v11 where we added those test cases.
--
--
Thanks & Regards,
Suraj kharage,
edbpostgres.com
Attachments:
remove_extra_semicolon_postgres_fdw.patchapplication/octet-stream; name=remove_extra_semicolon_postgres_fdw.patchDownload
diff --git a/contrib/postgres_fdw/expected/postgres_fdw.out b/contrib/postgres_fdw/expected/postgres_fdw.out
index 0649b6b..f2c91c4 100644
--- a/contrib/postgres_fdw/expected/postgres_fdw.out
+++ b/contrib/postgres_fdw/expected/postgres_fdw.out
@@ -8782,8 +8782,8 @@ INSERT INTO pagg_tab_p2 SELECT i % 30, i % 50, to_char(i/30, 'FM0000') FROM gene
INSERT INTO pagg_tab_p3 SELECT i % 30, i % 50, to_char(i/30, 'FM0000') FROM generate_series(1, 3000) i WHERE (i % 30) < 30 and (i % 30) >= 20;
-- Create foreign partitions
CREATE FOREIGN TABLE fpagg_tab_p1 PARTITION OF pagg_tab FOR VALUES FROM (0) TO (10) SERVER loopback OPTIONS (table_name 'pagg_tab_p1');
-CREATE FOREIGN TABLE fpagg_tab_p2 PARTITION OF pagg_tab FOR VALUES FROM (10) TO (20) SERVER loopback OPTIONS (table_name 'pagg_tab_p2');;
-CREATE FOREIGN TABLE fpagg_tab_p3 PARTITION OF pagg_tab FOR VALUES FROM (20) TO (30) SERVER loopback OPTIONS (table_name 'pagg_tab_p3');;
+CREATE FOREIGN TABLE fpagg_tab_p2 PARTITION OF pagg_tab FOR VALUES FROM (10) TO (20) SERVER loopback OPTIONS (table_name 'pagg_tab_p2');
+CREATE FOREIGN TABLE fpagg_tab_p3 PARTITION OF pagg_tab FOR VALUES FROM (20) TO (30) SERVER loopback OPTIONS (table_name 'pagg_tab_p3');
ANALYZE pagg_tab;
ANALYZE fpagg_tab_p1;
ANALYZE fpagg_tab_p2;
diff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/contrib/postgres_fdw/sql/postgres_fdw.sql
index 2b525ea..e9b3051 100644
--- a/contrib/postgres_fdw/sql/postgres_fdw.sql
+++ b/contrib/postgres_fdw/sql/postgres_fdw.sql
@@ -2538,8 +2538,8 @@ INSERT INTO pagg_tab_p3 SELECT i % 30, i % 50, to_char(i/30, 'FM0000') FROM gene
-- Create foreign partitions
CREATE FOREIGN TABLE fpagg_tab_p1 PARTITION OF pagg_tab FOR VALUES FROM (0) TO (10) SERVER loopback OPTIONS (table_name 'pagg_tab_p1');
-CREATE FOREIGN TABLE fpagg_tab_p2 PARTITION OF pagg_tab FOR VALUES FROM (10) TO (20) SERVER loopback OPTIONS (table_name 'pagg_tab_p2');;
-CREATE FOREIGN TABLE fpagg_tab_p3 PARTITION OF pagg_tab FOR VALUES FROM (20) TO (30) SERVER loopback OPTIONS (table_name 'pagg_tab_p3');;
+CREATE FOREIGN TABLE fpagg_tab_p2 PARTITION OF pagg_tab FOR VALUES FROM (10) TO (20) SERVER loopback OPTIONS (table_name 'pagg_tab_p2');
+CREATE FOREIGN TABLE fpagg_tab_p3 PARTITION OF pagg_tab FOR VALUES FROM (20) TO (30) SERVER loopback OPTIONS (table_name 'pagg_tab_p3');
ANALYZE pagg_tab;
ANALYZE fpagg_tab_p1;
On Tue, Mar 30, 2021 at 3:21 PM Suraj Kharage
<suraj.kharage@enterprisedb.com> wrote:
Hi,
Noticed that an extra semicolon in a couple of test cases related to postgres_fdw. Removed that in the attached patch. It can be backported till v11 where we added those test cases.
+1 for the change. It looks like a typo and can be backported.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
On Tue, Mar 30, 2021 at 4:50 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
On Tue, Mar 30, 2021 at 3:21 PM Suraj Kharage
<suraj.kharage@enterprisedb.com> wrote:Hi,
Noticed that an extra semicolon in a couple of test cases related to postgres_fdw. Removed that in the attached patch. It can be backported till v11 where we added those test cases.
+1 for the change. It looks like a typo and can be backported.
Looks good to me as well but I think one can choose not to backpatch
as there is no functional impact but OTOH, there is some value in
keeping tests/code consistent.
--
With Regards,
Amit Kapila.
On Tue, Mar 30, 2021 at 3:21 PM Suraj Kharage
<suraj.kharage@enterprisedb.com> wrote:
Hi,
Noticed that an extra semicolon in a couple of test cases related to postgres_fdw. Removed that in the attached patch. It can be backported till v11 where we added those test cases.
Thanks for identifying this, the changes look fine to me.
Regards,
Vignesh
On Tue, Mar 30, 2021 at 05:00:53PM +0530, Amit Kapila wrote:
Looks good to me as well but I think one can choose not to backpatch
as there is no functional impact but OTOH, there is some value in
keeping tests/code consistent.
FWIW, I would not bother with the back branches for just that, but if
you feel that this is better, of course feel free.
--
Michael
On Wed, Mar 31, 2021 at 9:35 AM Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Mar 30, 2021 at 05:00:53PM +0530, Amit Kapila wrote:
Looks good to me as well but I think one can choose not to backpatch
as there is no functional impact but OTOH, there is some value in
keeping tests/code consistent.FWIW, I would not bother with the back branches for just that, but if
you feel that this is better, of course feel free.
Fair enough. I'll push this just for HEAD.
--
With Regards,
Amit Kapila.
On Wed, Mar 31, 2021 at 9:47 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Wed, Mar 31, 2021 at 9:35 AM Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Mar 30, 2021 at 05:00:53PM +0530, Amit Kapila wrote:
Looks good to me as well but I think one can choose not to backpatch
as there is no functional impact but OTOH, there is some value in
keeping tests/code consistent.FWIW, I would not bother with the back branches for just that, but if
you feel that this is better, of course feel free.Fair enough. I'll push this just for HEAD.
Pushed!
--
With Regards,
Amit Kapila.