Jul 2021

1 commit
Fix assign_record_type_typmod().
10 Jul 2021Jeff Davismaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3REL_13_STABLE13.4+2 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #71 of 2 reviewers saw the final version

The commit preserves #7's deferred HASH_ENTER and allocation-before-copy approach in src/backend/utils/cache/typcache.c, but removes the temporary tdtypmod variable, delays NextRecordTypmod advancement until after successful allocation, and inserts the hash entry after identifier initialization. Jeff Davis confirms these revisions in #8.

  • Andres Freundsaw an earlier versiontrailerAndres defended separate hash lookup and insertion in #4 and identified an allocation-order leak in #6, reviewing #2 before subsequent allocation-order and counter changes.
  • Jeff Davissaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Sait Talha Nisanci1
Reviewer
Andres Freund1
Jeff Daviscommitter1
Committer
Jeff Davis1