Aug 2021

5 commits
Extend collection of Unicode combining characters to beyond the BMP
26 Aug 2021John Naylormaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #301 of 1 reviewer saw the final version

This lands only the fourth patch from #30: removing the 0xFFFF cutoff and adding the same 102 combining-character intervals. It adapts the paths and generated entries to the restored unicode_combining_table files, without the abandoned explicit width field.

  • Jacob Championsaw the final versionLLM analysis, 94% sureJacob identified the BMP limitation in #25 and gave the resulting series an overall positive review in #32; the committed extension preserves its cutoff removal and added intervals.
Update display widths as part of updating Unicode
26 Aug 2021John Naylormaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #132 of 2 reviewers saw the final version

The commit preserves the five-file implementation and identical generated wide-character table from #13. John replaces the arithmetic return with explicit branches, removes obsolete comments, and documents why combining characters must be searched first, as announced in #35.

  • Pavel Stehulesaw the final versionLLM analysis, 100% surePavel confirmed the alignment fix and benchmarked it in #14, then reported successful check-world testing and readiness for commit in #16, matching the commit's explicit review credit.
  • John Naylorsaw the final versioncommittercommitted the patch
Revert "Rename unicode_combining_table to unicode_width_table"
26 Aug 2021John Naylormaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1reverts 1 commit here
LLM analysis, 100% surewritten from the discussion, no matching patch

This restores the unicode_combining_table names in the Makefile, generator, header and wchar.c include. It implements John's decision to abandon the merged-table prerequisites after discovering overlapping Unicode properties #34; no attached patch proposes this revert.

Revert "Change mbbisearch to return the character range"
26 Aug 2021John Naylormaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1reverts 1 commit here
LLM analysis, 100% surewritten from the discussion, no matching patch

This reverses 78ab944cd4, restoring the boolean-style mbbisearch() result and removing the width field. John explains the overlapping combining/wide ranges and proposes this reversal in #34, without an attached revert patch.

Change mbbisearch to return the character range
25 Aug 2021John Naylormaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #301 of 1 reviewer saw the final version

This lands the second patch of #30, adding mbinterval.width and returning the matching interval from mbbisearch(). Minor edits move the range declaration before statements, use signed int for width, and leave generator-name corrections to the preceding rename commit; John confirms the warning fix in #33.

  • Jacob Championsaw the final versionLLM analysis, 100% sureJacob reported the mixed-declarations warning, approved the series and reported improved microbenchmark performance in #32, and the commit explicitly credits his review.

Credits across 5 commits

Author
John NaylorLLM2
Jacob ChampionLLM1
Reviewer
John Naylorcommitter1
Committer
John Naylor5

N LLM means N of the credits come from LLM analysis, not from commit trailers.