Jun 2021

4 commits
Add test case for obsoleting slot with active walsender, take 2
23 Jun 2021Alvaro Herreramaster14beta3REL_19_STABLE14beta3REL_18_STABLE14beta3REL_17_STABLE14beta3REL_16_STABLE14beta3REL_15_STABLE14beta3REL_14_STABLE14beta3
LLM analysis, 100% suremodified before commitlight changesfrom patchset #131 of 1 reviewer saw the final version

Reintroduces the test from #13 with synchronization fixes in src/test/recovery/t/019_replslot_limit.pl: capture the log offset before STOP, retry the termination-log search, match the sender PID and slot, and reduce WAL advancement. These implement Tom Lane's feedback in #16 and #17, as confirmed in #18.

  • Tom Lanesaw the final versionLLM analysis, 100% sureIdentified both log-search races and proposed more precise matching in #16 and #17, which the committer incorporated as test fixes.
Add test case for obsoleting slot with active walsender
18 Jun 2021Alvaro Herreramaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 100% surelanded as postedfrom patchset #13

Applying #13 to the commit's parent produces the same src/test/recovery/t/019_replslot_limit.pl content except for wrapping one find_in_log call across lines.

Return ReplicationSlotAcquire API to its original form
11 Jun 2021Alvaro Herreramaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #21 of 1 reviewer saw the final version

Takes the second patch of #2, restoring ReplicationSlotAcquire's boolean nowait API across five files, with adaptation to SearchNamedReplicationSlot's added argument and a comment reflow. The separate race-fix patch is excluded; #10 confirms this cleanup was pushed.

  • Álvaro Herrerasaw the final versiontrailerAgreed to remove the unnecessary API in #4 and committed the final version, announcing it in #10.
Fix race condition in invalidating obsolete replication slots
11 Jun 2021Alvaro Herreramaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2REL_13_STABLE13.4
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #80 of 1 reviewer saw the final version

Commits only the code portion of #8, adding ConditionVariablePrepareToSleep and restoring local lock reacquisition and retry in src/backend/replication/slot.c; the test remains uncommitted in #9. The commit credits Andres Freund and Alvaro Herrera as co-authors.

  • Amit Kapilasaw an earlier versionLLM analysis, 100% sureRead the initial patch and questioned missing ConditionVariableCancelSleep in #3, before subsequent lock-handling and condition-variable changes.

Credits across 4 commits

Author
Alvaro Herrera3
Andres Freund2
Reviewer
Alvaro Herrera1
Reported by
Andres Freund1
Committer
Alvaro Herrera4