model-writtenrun 7537 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Yulin PEI reported an assertion failure when creating a view that casts a collated string to integer, and asked whether to fix view creation or parse analysis in #1.
- Tom Lane identified an invalid CollateExpr around a non-collatable result and proposed dropping that wrapper during coercion, rather than changing DefineVirtualRelation(), in #2.
- Tom committed c402b02b9f after correcting the posted coerce_type() logic to preserve argument coercion and adding a regression test covering view deparsing; the fix was backpatched to all supported branches.
- The parser fix invalidated an ICU test that expected a collation dependency for an enum comparison, so Tom removed that test in cf0020080a, also linked to the discussion in thread #44013.
- After both commits, Yulin endorsed the original patch's intended behavior in #3 and supplied an additional create_cast regression test in #4; that attachment was not incorporated into either candidate commit.
- Further testing led Yulin to submit #5, correcting the original attachment's failure to coerce a nested CollateExpr argument to a non-collatable type; Tom explained in #6 that the committed fix already did this without an unnecessary node allocation.
- Yulin demonstrated the original attachment's failure with bit-string concatenation in #7, and Tom clarified in #8 that he had independently corrected that logic before committing, leaving the reported bug fixed and the later replacement patch unnecessary.