Jul 2021

3 commits
Teach pg_size_pretty and pg_size_bytes about petabytes
9 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #282 of 5 reviewers saw the final version

The commit retains the PB portion of #28, drops EB and the pg_proc.dat return-type change, and revises dbsize regression tests to exercise PB boundaries and signed inputs. Rowley explicitly confirms this reduced landing in #37.

  • Asif Rehmansaw an earlier versionLLM analysis, 98% sureAsif reported compilation failures in the earlier pg_size_bytes expansion in #4, which Christensen corrected before the implementation was substantially reworked.
  • Shinya Katosaw an earlier versionLLM analysis, 82% sureShinya questioned the need for yottabytes in #6 and supported separating unit expansion from refactoring in #14, a separation Christensen adopted.
  • Isaac Morlandsaw an earlier versionLLM analysis, 85% sureIsaac examined the original expansion in #10, proposing a common output format and questioning prefix handling, before the shared-table rewrite and reduction to PB.
  • Tom Lanesaw the final versionLLM analysis, 99% sureTom identified compatibility risks in changing the return type and argued for stopping at PB in #29, directly determining the committed scope.
  • David Rowleysaw the final versioncommittercommitted the patch
Use a lookup table for units in pg_size_pretty and pg_size_bytes
9 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #251 of 3 reviewers saw the final version

The shared table and three lookup loops match #25, but dbsize.c is adapted to the separately landed rounding fix: bigint transitions use division, numeric transitions call numeric_truncated_divide, and comments explain the revised arithmetic.

  • Dean Rasheedsaw the final versiontrailerDean challenged repeated rounding in #19, tested unit boundaries in #27, and reviewed and extended the prerequisite division fix in #33.
  • Tom Lanesaw an earlier versiontrailerTom requested a const label pointer and explained the typedef-name formatting problem in #23, before the rounding-transition logic was revised.
  • David Christensensaw an earlier versiontrailerChristensen endorsed the single table and reported successful testing in #22, before the rounding-transition rewrite and division fix.
Fix incorrect return value in pg_size_pretty(bigint)
9 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14beta3REL_13_STABLE13.4+4 more
LLM analysis, 100% surelanded as postedfrom patchset #33

The dbsize.c changes and both regression files match #33 modulo whitespace and patch metadata; normalized added and removed lines match exactly. The commit credits Rasheed and Rowley as co-authors, consistent with #32 and #33.

Credits across 3 commits

Author
David Rowley2
David Christensen1
Dean Rasheed1
Reviewer
David Christensen1
David Rowleycommitter1
Dean Rasheed1
Tom Lane1
Committer
David Rowley3