An omission of automatic completion in tab-complete.c

Started by wangw.fnst@fujitsu.comalmost 5 years ago4 messageshackers
Jump to latest
#1wangw.fnst@fujitsu.com
wangw.fnst@fujitsu.com

There is an omission of automatic completion of CURRENT_ROLE in tab-complete.c.

Best wishes,
Wei Wang

Attachments:

An-omission-of-automatic-completion-of-CURRENT_ROLE.patchapplication/octet-stream; name=An-omission-of-automatic-completion-of-CURRENT_ROLE.patchDownload+3-2
#2Michael Paquier
michael@paquier.xyz
In reply to: wangw.fnst@fujitsu.com (#1)
Re: An omission of automatic completion in tab-complete.c

On Tue, Apr 20, 2021 at 03:28:38AM +0000, wangw.fnst@fujitsu.com wrote:

There is an omission of automatic completion of CURRENT_ROLE in tab-complete.c.

Indeed, that looks like an omission from 45b9805.
--
Michael

#3Aleksander Alekseev
aleksander@timescale.com
In reply to: Michael Paquier (#2)
Re: An omission of automatic completion in tab-complete.c

There is an omission of automatic completion of CURRENT_ROLE in tab-complete.c.

I invested some time in checking this patch. It passes make
check-world / make installcheck-world and adds CURRENT_ROLE to the
automatic completion.

--
Best regards,
Aleksander Alekseev

#4Michael Paquier
michael@paquier.xyz
In reply to: Aleksander Alekseev (#3)
Re: An omission of automatic completion in tab-complete.c

On Tue, Apr 20, 2021 at 11:35:13AM +0300, Aleksander Alekseev wrote:

I invested some time in checking this patch. It passes make
check-world / make installcheck-world and adds CURRENT_ROLE to the
automatic completion.

Thanks Aleksander and Wei. Applied.
--
Michael