Typo in dshash_find() comments
Hi,
I just noticed that a comment for dshash_find() mentions:
"caller must not lock a lock already"
Simple patch to rephrase with "hold a lock" attached.
Attachments:
v1-typo-dshash_find.difftext/plain; charset=us-asciiDownload
diff --git a/src/backend/lib/dshash.c b/src/backend/lib/dshash.c
index e0c763be32..88ca9d62aa 100644
--- a/src/backend/lib/dshash.c
+++ b/src/backend/lib/dshash.c
@@ -375,7 +375,7 @@ dshash_get_hash_table_handle(dshash_table *hash_table)
* the caller must take care to ensure that the entry is not left corrupted.
* The lock mode is either shared or exclusive depending on 'exclusive'.
*
- * The caller must not lock a lock already.
+ * The caller must not hold a lock already.
*
* Note that the lock held is in fact an LWLock, so interrupts will be held on
* return from this function, and not resumed until dshash_release_lock is
On Tue, Apr 20, 2021 at 2:16 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
Hi,
I just noticed that a comment for dshash_find() mentions:
"caller must not lock a lock already"
Simple patch to rephrase with "hold a lock" attached.
Pushed, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
On Tue, Apr 20, 2021 at 02:37:16PM +0200, Magnus Hagander wrote:
On Tue, Apr 20, 2021 at 2:16 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
Hi,
I just noticed that a comment for dshash_find() mentions:
"caller must not lock a lock already"
Simple patch to rephrase with "hold a lock" attached.
Pushed, thanks.
Thanks Magnus!