Remove redundant variable pageSize in gistinitpage
Started by Bharath Rupireddyalmost 5 years ago2 messageshackers
Hi,
In gistinitpage, pageSize variable looks redundant, instead we could
just pass BLCKSZ. This will be consistent with its peers
BloomInitPage, brin_page_init and SpGistInitPage. Attaching a small
patch. Thoughts?
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
Attachments:
v1-0001-Remove-redundant-variable-pageSize-in-gistinitpag.patchapplication/x-patch; name=v1-0001-Remove-redundant-variable-pageSize-in-gistinitpag.patchDownload+1-3
Re: Remove redundant variable pageSize in gistinitpage
On 26.04.21 05:12, Bharath Rupireddy wrote:
In gistinitpage, pageSize variable looks redundant, instead we could
just pass BLCKSZ. This will be consistent with its peers
BloomInitPage, brin_page_init and SpGistInitPage. Attaching a small
patch. Thoughts?
Committed.
This code was new in this form in PG14
(16fa9b2b30a357b4aea982bd878ec2e5e002dbcc), so it made sense to clean it
up now.