Jul 2021

1 commit
Improve reporting of "conflicting or redundant options" errors.
15 Jul 2021Dean Rasheedmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #641 of 8 reviewers saw the final version

The commit retains #64's shared helper, ParseState plumbing and regression output, but omits ten helper conversions in tablecmds.c, pgoutput.c and walsender.c where ParseState is unavailable. It also removes the redundant null guard in define.c and accommodates the new two_phase subscription option; Dean explains the omissions and simplification in #66, while the commit credits Vignesh's underlying patch.

  • Bharath Rupireddysaw an earlier versionLLM analysis, 99% sureBharath reviewed successive versions, proposed consolidating error reports in #28, and endorsed the shared helper in #47, before the later error-message redesign.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 99% sureAlvaro requested wider ParseState propagation in #29, proposed the shared reporting function in #46, and corrected its implementation in #50, before Dean's final redesign.
  • Dilip Kumarsaw an earlier versionLLM analysis, 98% sureDilip requested errdetail in #3, identified control-flow problems in the companion revisions in #16, #20 and #23, and endorsed the consolidated goto approach in #37.
  • Zhijie Hou (Fujitsu)saw an earlier versionLLM analysis, 100% sureZhijie identified unnecessary compiler-quiet comments and returns in #40 and #44, prompting cleanup before the subsequent shared-helper redesign.
  • Peter Smithsaw an earlier versionLLM analysis, 96% surePeter challenged the companion patch's replacement of gotos with boolean flags in #22, helping lead to its replacement by the minimal change in #24.
  • Daniel Gustafssonsaw an earlier versionLLM analysis, 100% sureDaniel judged the shared-helper patch positively and identified unnecessary variable-declaration changes in #54, which #55 removed before the later semantic revisions.
  • Julien Rouhaudsaw an earlier versionLLM analysis, 92% sureJulien supported adding cursor positions wherever possible in #33, a design decision implemented in #34, and is explicitly credited as a reviewer in 2bfb50b3df.
  • Dean Rasheedsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
vignesh CLLM1
Reviewer
Dean Rasheedcommitter1
Committer
Dean Rasheed1

N LLM means N of the credits come from LLM analysis, not from commit trailers.